Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(684)

Issue 828703002: separate picture info from cc.debug (Closed)

Created:
5 years, 12 months ago by JungJik
Modified:
5 years, 11 months ago
Reviewers:
nduca, vmpstr
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

separate picture info from cc.debug cc.debug includes pictures, resources and other layers info. a picture has skia data which is encoded by base64 format. the skia data is too big to send via IPC. so we can not see other tracing info. this patch is for separating the picture data from cc.debug. BUG=446425 Committed: https://crrev.com/d9172a7dfca4561cf2dfdc9463ccf5f20b88d404 Cr-Commit-Position: refs/heads/master@{#310680}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M cc/resources/picture.cc View 3 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
JungJik
PTAL :)
5 years, 11 months ago (2015-01-06 09:28:50 UTC) #2
JungJik
On 2015/01/06 09:28:50, JungJik wrote: > PTAL :) And I am trying to flush the ...
5 years, 11 months ago (2015-01-06 14:13:52 UTC) #3
vmpstr
Is it safe to say that this change will only change the checkboxes behavior in ...
5 years, 11 months ago (2015-01-06 18:50:24 UTC) #5
JungJik
On 2015/01/06 18:50:24, vmpstr wrote: > Is it safe to say that this change will ...
5 years, 11 months ago (2015-01-07 10:42:20 UTC) #6
vmpstr
lgtm
5 years, 11 months ago (2015-01-07 16:47:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/828703002/1
5 years, 11 months ago (2015-01-09 01:15:36 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-09 02:35:58 UTC) #12
commit-bot: I haz the power
5 years, 11 months ago (2015-01-09 02:38:04 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d9172a7dfca4561cf2dfdc9463ccf5f20b88d404
Cr-Commit-Position: refs/heads/master@{#310680}

Powered by Google App Engine
This is Rietveld 408576698