Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(575)

Issue 828633002: replace COMPILE_ASSERT with static_assert in ui/ (Closed)

Created:
5 years, 12 months ago by Mostyn Bramley-Moore
Modified:
5 years, 11 months ago
Reviewers:
tfarina, sky
CC:
chromium-reviews, tdanderson+views_chromium.org, sadrul, yusukes+watch_chromium.org, derat+watch_chromium.org, yukishiino+watch_chromium.org, tfarina, tdresser+watch_chromium.org, penghuang+watch_chromium.org, nona+watch_chromium.org, kalyank, James Su, jdduke+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

replace COMPILE_ASSERT with static_assert in ui/ BUG=442514 R=sky@chromium.org Committed: https://crrev.com/5e16d46c92747ae76914b9a5db114a19cdb00bde Cr-Commit-Position: refs/heads/master@{#311435}

Patch Set 1 #

Patch Set 2 : rebased on master #

Patch Set 3 : rebase on master #

Patch Set 4 : fix for rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -32 lines) Patch
M ui/aura/window_property.h View 1 2 3 1 chunk +11 lines, -11 lines 0 comments Download
M ui/aura/window_tree_host_x11.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M ui/base/ime/win/imm32_manager.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ui/base/layout.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/base/resource/data_pack.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/base/x/selection_owner.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/base/x/selection_requestor.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/events/gesture_detection/touch_disposition_gesture_filter.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M ui/events/gesture_detection/velocity_tracker.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/native_theme/native_theme_aura.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download
M ui/native_theme/native_theme_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M ui/platform_window/x11/x11_window.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 26 (11 generated)
Mostyn Bramley-Moore
@sky: please take a look.
5 years, 11 months ago (2015-01-05 22:06:10 UTC) #2
tfarina
lgtm
5 years, 11 months ago (2015-01-05 23:12:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/828633002/20001
5 years, 11 months ago (2015-01-05 23:54:10 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/33257)
5 years, 11 months ago (2015-01-06 00:01:10 UTC) #8
Mostyn Bramley-Moore
@sky: *ping*
5 years, 11 months ago (2015-01-13 09:00:57 UTC) #9
sky
LGTM
5 years, 11 months ago (2015-01-13 18:30:37 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/828633002/20001
5 years, 11 months ago (2015-01-13 19:51:32 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/35630)
5 years, 11 months ago (2015-01-13 19:57:57 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/828633002/40001
5 years, 11 months ago (2015-01-13 20:32:18 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/49468)
5 years, 11 months ago (2015-01-13 20:41:37 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/828633002/60001
5 years, 11 months ago (2015-01-13 20:46:18 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/22969)
5 years, 11 months ago (2015-01-13 22:09:43 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/828633002/60001
5 years, 11 months ago (2015-01-14 08:56:43 UTC) #24
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 11 months ago (2015-01-14 09:33:44 UTC) #25
commit-bot: I haz the power
5 years, 11 months ago (2015-01-14 09:35:16 UTC) #26
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/5e16d46c92747ae76914b9a5db114a19cdb00bde
Cr-Commit-Position: refs/heads/master@{#311435}

Powered by Google App Engine
This is Rietveld 408576698