Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2365)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/ui/toolbar/wrench_menu_model_unittest.cc

Issue 8286018: Reland r105450: Linux: add basic bookmark menu support. More features can be added later. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/toolbar/wrench_menu_model.cc ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/toolbar/wrench_menu_model_unittest.cc
===================================================================
--- chrome/browser/ui/toolbar/wrench_menu_model_unittest.cc (revision 105454)
+++ chrome/browser/ui/toolbar/wrench_menu_model_unittest.cc (working copy)
@@ -149,6 +149,8 @@
EXPECT_GT(bookmarksModelIndex, -1);
ui::MenuModel* bookmarksModel = model.GetSubmenuModelAt(bookmarksModelIndex);
EXPECT_TRUE(bookmarksModel);
+ // The bookmarks model may be empty until we tell it we're going to show it.
+ bookmarksModel->MenuWillShow();
EXPECT_GT(bookmarksModel->GetItemCount(), 1);
bookmarksModel->ActivatedAt(1);
EXPECT_TRUE(bookmarksModel->IsEnabledAt(1));
« no previous file with comments | « chrome/browser/ui/toolbar/wrench_menu_model.cc ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698