Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(969)

Issue 828553007: Wrok around MSVC bug 1085387. (Closed)

Created:
5 years, 11 months ago by JF
Modified:
5 years, 11 months ago
Reviewers:
Derek Schuff
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-llvm.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Wrok around MSVC bug 1085387. Work around the following bug: https://connect.microsoft.com/VisualStudio/feedback/details/1085387 Patched in Emscripten by juj: https://github.com/kripken/emscripten-fastcomp/pull/61 Discussed fixing differently with clb on Emscripten's IRC channel. R=dschuff@chromium.org TEST= build with MSVC BUG= doesn't build with MSVC Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-llvm.git;a=commit;h=29bca5570ce2cf268339e395918951ef2d882456

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M lib/Transforms/NaCl/FlattenGlobals.cpp View 3 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
JF
5 years, 11 months ago (2015-01-12 19:11:49 UTC) #1
Derek Schuff
lgtm
5 years, 11 months ago (2015-01-12 19:16:38 UTC) #2
JF
Committed patchset #1 (id:1) manually as 29bca5570ce2cf268339e395918951ef2d882456 (presubmit successful).
5 years, 11 months ago (2015-01-12 19:17:21 UTC) #3
JF
5 years, 11 months ago (2015-01-12 19:28:42 UTC) #4
Message was sent while issue was closed.
That wasn't quite correct, fixed properly in:
  https://codereview.chromium.org/846953002/

Powered by Google App Engine
This is Rietveld 408576698