Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 828453003: Revert of Templatize visitor arguments for TraceTrait mark and trace methods. (Closed)

Created:
5 years, 12 months ago by kouhei (in TOK)
Modified:
5 years, 12 months ago
CC:
aandrey+blink_chromium.org, Mads Ager (chromium), blink-reviews, blink-reviews-wtf_chromium.org, kouhei+heap_chromium.org, Mikhail, oilpan-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of Templatize visitor arguments for TraceTrait mark and trace methods. (patchset #6 id:100001 of https://codereview.chromium.org/807003004/) Reason for revert: Breaks msvc: http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win%20Oilpan%20%28dbg%29/builds/4695 Original issue's description: > Templatize visitor arguments for TraceTrait mark and trace methods. > > This CL replaces Visitor* in TraceTrait<T>::{mark,trace} methods arguments > to template parameter VisitorDispatcher. > > This is to prepare for InlinedGlobalMarkingVisitor implementaion, so that > those methods can also be used to dispatch > TraceTrait<T>::mark(InlinedGlobalMarkingVisitor) in addition to the current > TraceTrait<T>::mark(Visitor*) usage. > > BUG=420515 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187674 TBR=jochen@chromium.org,erik.corry@gmail.com,haraken@chromium.org,oilpan-reviews@chromium.org,sigbjornf@opera.com BUG=420515 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187698

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -97 lines) Patch
M Source/platform/heap/Heap.h View 17 chunks +25 lines, -54 lines 0 comments Download
M Source/platform/heap/HeapTest.cpp View 3 chunks +1 line, -4 lines 0 comments Download
M Source/platform/heap/Visitor.h View 5 chunks +7 lines, -12 lines 0 comments Download
M Source/wtf/Deque.h View 3 chunks +5 lines, -6 lines 0 comments Download
M Source/wtf/HashTable.h View 3 chunks +3 lines, -4 lines 0 comments Download
M Source/wtf/TypeTraits.h View 2 chunks +4 lines, -13 lines 0 comments Download
M Source/wtf/Vector.h View 2 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
kouhei (in TOK)
Created Revert of Templatize visitor arguments for TraceTrait mark and trace methods.
5 years, 12 months ago (2014-12-25 01:39:10 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/828453003/1
5 years, 12 months ago (2014-12-25 01:41:02 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_compile_dbg on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_compile_dbg/builds/30761) win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/43670) win_gpu ...
5 years, 12 months ago (2014-12-25 01:45:38 UTC) #5
sof
lgtm
5 years, 12 months ago (2014-12-25 19:23:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/828453003/1
5 years, 12 months ago (2014-12-25 19:23:09 UTC) #8
commit-bot: I haz the power
5 years, 12 months ago (2014-12-25 20:21:38 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187698

Powered by Google App Engine
This is Rietveld 408576698