Chromium Code Reviews
DescriptionRevert of Templatize visitor arguments for TraceTrait mark and trace methods. (patchset #6 id:100001 of https://codereview.chromium.org/807003004/)
Reason for revert:
Breaks msvc: http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win%20Oilpan%20%28dbg%29/builds/4695
Original issue's description:
> Templatize visitor arguments for TraceTrait mark and trace methods.
>
> This CL replaces Visitor* in TraceTrait<T>::{mark,trace} methods arguments
> to template parameter VisitorDispatcher.
>
> This is to prepare for InlinedGlobalMarkingVisitor implementaion, so that
> those methods can also be used to dispatch
> TraceTrait<T>::mark(InlinedGlobalMarkingVisitor) in addition to the current
> TraceTrait<T>::mark(Visitor*) usage.
>
> BUG=420515
>
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187674
TBR=jochen@chromium.org,erik.corry@gmail.com,haraken@chromium.org,oilpan-reviews@chromium.org,sigbjornf@opera.com
BUG=420515
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187698
Patch Set 1 #
Created: 5 years, 12 months ago
(Patch set is too large to download)
Messages
Total messages: 9 (3 generated)
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||