Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 828433004: Fix renderName on RenderBlock and RenderParagraph. (Closed)

Created:
5 years, 11 months ago by ojan
Modified:
5 years, 11 months ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Fix renderName on RenderBlock and RenderParagraph. RenderBlock should indicate when something is an inline-block. RenderParagraph should not print out RenderBlock. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/01a371959f81897f070dd279c2db6516bda46455

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -105 lines) Patch
M sky/engine/core/rendering/RenderBlock.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M sky/engine/core/rendering/RenderParagraph.h View 1 chunk +2 lines, -0 lines 0 comments Download
M sky/engine/core/rendering/RenderParagraph.cpp View 1 chunk +7 lines, -0 lines 0 comments Download
M sky/tests/clipping/background-opaque-clipped-gradients-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M sky/tests/clipping/canvas-rounded-corners-expected.txt View 1 chunk +4 lines, -4 lines 0 comments Download
M sky/tests/framework/citylist-expected.txt View 18 chunks +22 lines, -22 lines 0 comments Download
M sky/tests/framework/citylist-scrolled-expected.txt View 17 chunks +23 lines, -23 lines 0 comments Download
M sky/tests/framework/flights-app-expected.txt View 11 chunks +22 lines, -22 lines 0 comments Download
M sky/tests/layout/ellipsis-expected.txt View 1 chunk +4 lines, -4 lines 0 comments Download
M sky/tests/lowlevel/abarth-expected.txt View 1 chunk +8 lines, -8 lines 0 comments Download
M sky/tests/lowlevel/hello-world-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M sky/tests/lowlevel/iframe-expected.txt View 1 chunk +5 lines, -5 lines 0 comments Download
M sky/tests/lowlevel/scrollbar-expected.txt View 1 chunk +15 lines, -15 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
abarth-chromium
lgtm
5 years, 11 months ago (2015-01-09 00:55:55 UTC) #2
ojan
5 years, 11 months ago (2015-01-09 01:14:21 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
01a371959f81897f070dd279c2db6516bda46455 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698