Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Issue 828403005: Revert of Give asan/win bot a very generous timeout. (Closed)

Created:
5 years, 11 months ago by Nico
Modified:
5 years, 11 months ago
Reviewers:
Timur Iskhodzhanov
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Give asan/win bot a very generous timeout. (patchset #1 id:1 of https://codereview.chromium.org/557333007/) Reason for revert: Didn't help, wasn't the cause (see bug). Original issue's description: > Give asan/win bot a very generous timeout. > > The previous increase in r293993 didn't help anything; make the timeout really > large to make sure that things aren't just slow. (Once this hasn't helped > either, we're going to remove this win/asan special case.) > > BUG=412471 > TBR=timurrrr@chromium.org > NOTRY=true > > Committed: https://crrev.com/207907c24b8cee246ff713342a1055277b64355d > Cr-Commit-Position: refs/heads/master@{#294242} TBR=timurrrr@chromium.org NOTREECHECKS=true NOTRY=true BUG=412471 Committed: https://crrev.com/1fba5a6ae9834e09e5716de54559e41ef9b2d980 Cr-Commit-Position: refs/heads/master@{#311695}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M base/test/test_timeouts.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Nico
Created Revert of Give asan/win bot a very generous timeout.
5 years, 11 months ago (2015-01-15 18:14:58 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/828403005/1
5 years, 11 months ago (2015-01-15 18:16:54 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-15 18:18:25 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/1fba5a6ae9834e09e5716de54559e41ef9b2d980 Cr-Commit-Position: refs/heads/master@{#311695}
5 years, 11 months ago (2015-01-15 18:19:25 UTC) #4
Timur Iskhodzhanov
5 years, 11 months ago (2015-01-19 14:25:55 UTC) #5
Message was sent while issue was closed.
LGTM, thanks!

Powered by Google App Engine
This is Rietveld 408576698