Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 828373007: Fix math support on wikipedia. (Closed)

Created:
5 years, 11 months ago by David Tseng
Modified:
5 years, 11 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews, oshima+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, nkostylev+watch_chromium.org, yuzo+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, stevenjb+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixmath support on wikipedia. Wikipedia now assigns a fallback classname to its 'tex' img nodes. ChromeVox, reading the className directly, needs to split the space delimited string. BUG=448544 TEST=math now reads on wikipedia Committed: https://crrev.com/4d2da89db85b25313a829e722965a99a9d4e8abe Cr-Commit-Position: refs/heads/master@{#311529}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Use classList #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M chrome/browser/resources/chromeos/chromevox/common/dom_util.js View 1 1 chunk +8 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
David Tseng
5 years, 11 months ago (2015-01-13 22:59:37 UTC) #2
dmazzoni
lgtm lgtm with one issue https://codereview.chromium.org/828373007/diff/1/chrome/browser/resources/chromeos/chromevox/common/dom_util.js File chrome/browser/resources/chromeos/chromevox/common/dom_util.js (right): https://codereview.chromium.org/828373007/diff/1/chrome/browser/resources/chromeos/chromevox/common/dom_util.js#newcode2450 chrome/browser/resources/chromeos/chromevox/common/dom_util.js:2450: return node.className.toLowerCase().split(' ').some(function(className) { ...
5 years, 11 months ago (2015-01-14 08:20:34 UTC) #3
David Tseng
https://codereview.chromium.org/828373007/diff/1/chrome/browser/resources/chromeos/chromevox/common/dom_util.js File chrome/browser/resources/chromeos/chromevox/common/dom_util.js (right): https://codereview.chromium.org/828373007/diff/1/chrome/browser/resources/chromeos/chromevox/common/dom_util.js#newcode2450 chrome/browser/resources/chromeos/chromevox/common/dom_util.js:2450: return node.className.toLowerCase().split(' ').some(function(className) { On 2015/01/14 08:20:34, dmazzoni wrote: ...
5 years, 11 months ago (2015-01-14 18:17:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/828373007/20001
5 years, 11 months ago (2015-01-14 18:18:44 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-14 19:14:16 UTC) #7
commit-bot: I haz the power
5 years, 11 months ago (2015-01-14 19:15:15 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4d2da89db85b25313a829e722965a99a9d4e8abe
Cr-Commit-Position: refs/heads/master@{#311529}

Powered by Google App Engine
This is Rietveld 408576698