Made gdb-add-index respect TOOLCHAIN_PREFIX settings.

Made gdb-add-index respect TOOLCHAIN_PREFIX settings.

This allows the script to work for remote debugging cross-compiled
binaries by adding a prefix such as arm-linux-gnueabi- to all of the
binutils commands.

BUG=

Committed: https://crrev.com/cdc89dff37a8adb59c92f463514fbab48d7abaff
Cr-Commit-Position: refs/heads/master@{#310640}

[cleichner, 2015-01-08 22:18:00]

cleichner@chromium.org changed reviewers:
+ cjhopman@chromium.org

[cleichner, 2015-01-08 22:18:40]

cleichner@chromium.org changed reviewers:
+ scottmg@chromium.org

[cjhopman, 2015-01-08 22:37:24]

lgtm

https://codereview.chromium.org/828373003/diff/20001/build/gdb-add-index
File build/gdb-add-index (right):

https://codereview.chromium.org/828373003/diff/20001/build/gdb-add-index#newc...
build/gdb-add-index:41: local readelf_out=$(${CROSS_COMPILE}readelf -S "$file")
To match the naming of this elsewhere (e.g. gyp), I'd call it TOOLCHAIN_PREFIX.

[scottmg, 2015-01-08 22:38:59]

https://codereview.chromium.org/828373003/diff/20001/build/gdb-add-index
File build/gdb-add-index (right):

https://codereview.chromium.org/828373003/diff/20001/build/gdb-add-index#newc...
build/gdb-add-index:63: local elappsed=$(((finish - start)/1000000))
would you mind fixing the spelling of "elapsed" while you're here?

[cleichner, 2015-01-08 22:39:29]

The CQ bit was checked by cleichner@chromium.org

[cleichner, 2015-01-08 22:39:43]

The CQ bit was unchecked by cleichner@chromium.org

[cleichner, 2015-01-08 22:42:46]

PTAL

https://codereview.chromium.org/828373003/diff/20001/build/gdb-add-index
File build/gdb-add-index (right):

https://codereview.chromium.org/828373003/diff/20001/build/gdb-add-index#newc...
build/gdb-add-index:41: local readelf_out=$(${CROSS_COMPILE}readelf -S "$file")
On 2015/01/08 22:37:23, cjhopman wrote:
> To match the naming of this elsewhere (e.g. gyp), I'd call it
TOOLCHAIN_PREFIX.

Done.

https://codereview.chromium.org/828373003/diff/20001/build/gdb-add-index#newc...
build/gdb-add-index:63: local elappsed=$(((finish - start)/1000000))
On 2015/01/08 22:38:59, scottmg wrote:
> would you mind fixing the spelling of "elapsed" while you're here?

Done.

[cleichner, 2015-01-08 22:51:08]

The CQ bit was checked by cleichner@chromium.org

[commit-bot: I haz the power, 2015-01-08 22:51:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/828373003/40001

[commit-bot: I haz the power, 2015-01-09 00:37:18]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-01-09 00:38:47]

Patchset 3 (id:??) landed as
https://crrev.com/cdc89dff37a8adb59c92f463514fbab48d7abaff
Cr-Commit-Position: refs/heads/master@{#310640}