Issue 828343003: Stricter parsing for rowSpan/ColSpan on th/td element

Issue 828343003: Stricter parsing for rowSpan/ColSpan on th/td element (Closed)

Created:
5 years, 11 months ago by rwlbuis

Modified:
5 years, 11 months ago

Reviewers:
Hajime Morrita, kouhei (in TOK)

CC:
blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

Stricter parsing for rowSpan/ColSpan on th/td element According to the latest spec "The td and th elements may have a colspan content attribute specified, whose value must be a valid non-negative integer greater than zero." With this patch parsing is more strict and above rules are honored. This was showing as failures here, fixed with this patch: http://w3c-test.org/html/dom/reflection-tabular.html Behavior matches Firefox. Spec reference: https://html.spec.whatwg.org/#attributes-common-to-td-and-th-elements Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188625

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+171 lines, -2 lines)			Patch
A	LayoutTests/fast/dom/HTMLTableCellElement/colspan-attribute.html	View	1 2	1 chunk	+50 lines, -0 lines	0 comments	Download
A	LayoutTests/fast/dom/HTMLTableCellElement/colspan-attribute-expected.txt	View	1 2	1 chunk	+31 lines, -0 lines	0 comments	Download
A	LayoutTests/fast/dom/HTMLTableCellElement/rowspan-attribute.html	View	1	1 chunk	+50 lines, -0 lines	0 comments	Download
A	LayoutTests/fast/dom/HTMLTableCellElement/rowspan-attribute-expected.txt	View	1	1 chunk	+31 lines, -0 lines	0 comments	Download
M	Source/core/html/HTMLTableCellElement.cpp	View		2 chunks	+9 lines, -2 lines	0 comments	Download

Total messages: 6 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/828343003/40001

5 years, 11 months ago (2015-01-19 12:41:44 UTC) #5

commit-bot: I haz the power

5 years, 11 months ago (2015-01-19 13:59:15 UTC) #6

Message was sent while issue was closed.

Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188625