Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 828303002: [x64] Rearrange code for OOB integer loads. (Closed)

Created:
5 years, 11 months ago by Benedikt Meurer
Modified:
5 years, 11 months ago
Reviewers:
Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[x64] Rearrange code for OOB integer loads. We cannot just clear the result register optimistically, because the register allocator might assign the same register to result and buffer. TEST=mjsunit/compiler/regress-445858 BUG=chromium:445858 LOG=y R=jarin@chromium.org Committed: https://crrev.com/cf866b7c612c25bace7d0f0ceb12456e5ad24d7f Cr-Commit-Position: refs/heads/master@{#25950}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -8 lines) Patch
M src/compiler/x64/code-generator-x64.cc View 1 chunk +5 lines, -2 lines 0 comments Download
A + test/mjsunit/compiler/regress-445858.js View 1 chunk +5 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Benedikt Meurer
5 years, 11 months ago (2015-01-02 09:44:59 UTC) #1
Benedikt Meurer
PTAL
5 years, 11 months ago (2015-01-02 09:45:15 UTC) #2
Jarin
lgtm
5 years, 11 months ago (2015-01-02 09:52:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/828303002/1
5 years, 11 months ago (2015-01-02 09:53:08 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-02 10:15:32 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-02 10:15:46 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cf866b7c612c25bace7d0f0ceb12456e5ad24d7f
Cr-Commit-Position: refs/heads/master@{#25950}

Powered by Google App Engine
This is Rietveld 408576698