Issue 82823004: Use new GURL::SchemeIsWSOrWSS method in HttpNetworkTransaction

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 82823004: Use new GURL::SchemeIsWSOrWSS method in HttpNetworkTransaction (Closed)

Created:
7 years, 1 month ago by Adam Rice

Modified:
7 years, 1 month ago

Reviewers:
szym

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

HttpNetworkTransaction needs to check if the URL scheme is one appropriate for WebSockets. Use the new GURL::SchemeIsWSOrWSS method to do the check. BUG= TEST=net_unittests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=236964

Patch Set 1 #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	net/http/http_network_transaction.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ricea@chromium.org/82823004/1

7 years, 1 month ago (2013-11-23 03:04:52 UTC) #3

commit-bot: I haz the power

Retried try job too often on linux_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=194339

7 years, 1 month ago (2013-11-23 04:50:32 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ricea@chromium.org/82823004/1

7 years, 1 month ago (2013-11-23 07:54:52 UTC) #5

Message was sent while issue was closed.

Change committed as 236964

Expand Messages | Collapse Messages