Issue 828163004: Require clang formatting for components/password_manager.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 828163004: Require clang formatting for components/password_manager. (Closed)

Created:
5 years, 11 months ago by Mike West

Modified:
5 years, 11 months ago

Reviewers:
vabr (Chromium)

CC:
chromium-reviews, gcasto+watchlist_chromium.org, mkwst+watchlist-passwords_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Require clang formatting for components/password_manager. Hooray for not asking about style nits anymore! R=vabr@chromium.org Committed: https://crrev.com/cbd80a7dc6cc82de386de444a369f6b949401315 Cr-Commit-Position: refs/heads/master@{#311451}

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -0 lines)			Patch
	A	components/password_manager/PRESUBMIT.py	View	1	1 chunk	+12 lines, -0 lines	0 comments	Download

Total messages: 6 (1 generated)

Mike West

vabr@, WDYT? I'll give MTV a chance to comment before landing this.

5 years, 11 months ago (2015-01-13 09:12:16 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/828163004/20001

5 years, 11 months ago (2015-01-14 09:05:55 UTC) #4

commit-bot: I haz the power

5 years, 11 months ago (2015-01-14 11:16:58 UTC) #6

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/cbd80a7dc6cc82de386de444a369f6b949401315
Cr-Commit-Position: refs/heads/master@{#311451}