Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(505)

Unified Diff: third_party/google_input_tools/src/chrome/os/inputview/util.js

Issue 828063007: Uprev Google Input Tools. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update extensions schema. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/google_input_tools/src/chrome/os/inputview/util.js
diff --git a/third_party/google_input_tools/src/chrome/os/inputview/util.js b/third_party/google_input_tools/src/chrome/os/inputview/util.js
index e68526ca6ae92668586bbafe890898517f0abb79..e29accd99d1675a1275a76d64ba44733727176fc 100644
--- a/third_party/google_input_tools/src/chrome/os/inputview/util.js
+++ b/third_party/google_input_tools/src/chrome/os/inputview/util.js
@@ -95,7 +95,6 @@ util.KEYSETS_HAVE_EN_SWTICHER = [
* @type {!Array.<string>}
*/
util.KEYSETS_HAVE_COMPACT = [
- 'be',
'ca',
'ca-eng',
'de',
@@ -105,6 +104,7 @@ util.KEYSETS_HAVE_COMPACT = [
'gb-extd',
'ie',
'is',
+ 'nl',
'no',
'pinyin-zh-CN',
'se',
@@ -266,6 +266,11 @@ util.getVisibleCharacter = function(invisibleCharacter) {
if (map[invisibleCharacter]) {
return map[invisibleCharacter];
}
+ // For non-spacing marks (e.g. \u05b1), ChromeOS cannot display it correctly
+ // until there is a character before it to combine with.
+ if (/[\u0591-\u05cf]/.test(invisibleCharacter)) {
+ return '\u00a0' + invisibleCharacter;
+ }
return invisibleCharacter;
};

Powered by Google App Engine
This is Rietveld 408576698