Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 828063005: Reenabled all except for ref and XP build of service_worker_micro_benchmark. (Closed)

Created:
5 years, 11 months ago by horo
Modified:
5 years, 11 months ago
Reviewers:
qyearsley, nhiroki
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@Test
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reenabled all except for ref and XP build of service_worker_micro_benchmark. We can't enable on the ref build because SW doesn't work on M37. And also we disable on XP because of test flakiness. BUG=442752 Committed: https://crrev.com/7a1d0c43d850d4fbef962a5f018e2a5c2483b9a5 Cr-Commit-Position: refs/heads/master@{#310727}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/perf/benchmarks/service_worker.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (5 generated)
horo
nhiroki@ Could you please review? I couldn't find the root cause of the failure on ...
5 years, 11 months ago (2015-01-09 01:17:33 UTC) #2
nhiroki
lgtm
5 years, 11 months ago (2015-01-09 02:17:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/828063005/1
5 years, 11 months ago (2015-01-09 03:13:02 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/34360)
5 years, 11 months ago (2015-01-09 03:22:02 UTC) #7
horo
qyearsley@ Please review this. Thank you.
5 years, 11 months ago (2015-01-09 05:00:20 UTC) #9
qyearsley
On 2015/01/09 05:00:20, horo wrote: > qyearsley@ > Please review this. > > Thank you. ...
5 years, 11 months ago (2015-01-09 05:59:44 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/828063005/1
5 years, 11 months ago (2015-01-09 06:43:01 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-09 07:41:54 UTC) #13
commit-bot: I haz the power
5 years, 11 months ago (2015-01-09 07:42:55 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7a1d0c43d850d4fbef962a5f018e2a5c2483b9a5
Cr-Commit-Position: refs/heads/master@{#310727}

Powered by Google App Engine
This is Rietveld 408576698