Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 827953002: Make NavigatorConnectProvider finalize its owned callback objects. (Closed)

Created:
5 years, 11 months ago by sof
Modified:
5 years, 11 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, oilpan-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make NavigatorConnectProvider finalize its owned callback objects. Add missing IDMapOwnPointer annotation to have ConnectCallback objects be destructed and finalized once done with, as the provider owns these. Needed with Oilpan enabled to prevent persistent strong references from going missing, and not being cleared in a timely fashion. R=mek,mkwst BUG=445388 Committed: https://crrev.com/419f0760c569b7837b42636a61e0bace316e65a5 Cr-Commit-Position: refs/heads/master@{#309713}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/child/navigator_connect/navigator_connect_provider.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (2 generated)
sof
Please take a look. Fixes immediate cause of some Oilpan untowardness.
5 years, 11 months ago (2014-12-29 16:47:50 UTC) #2
Mike West
LGTM. I'm not an owner here, but I think this is safe to TBR to ...
5 years, 11 months ago (2014-12-29 16:53:52 UTC) #3
Marijn Kruisselbrink
On 2014/12/29 16:47:50, sof wrote: > Please take a look. > > Fixes immediate cause ...
5 years, 11 months ago (2014-12-29 16:54:29 UTC) #4
haraken
LGTM
5 years, 11 months ago (2014-12-29 17:08:40 UTC) #5
sof
Thanks all for the quick reviews; best wishes for 2015.
5 years, 11 months ago (2014-12-29 18:46:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/827953002/1
5 years, 11 months ago (2014-12-29 18:47:37 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2014-12-29 19:34:55 UTC) #9
commit-bot: I haz the power
5 years, 11 months ago (2014-12-29 19:35:49 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/419f0760c569b7837b42636a61e0bace316e65a5
Cr-Commit-Position: refs/heads/master@{#309713}

Powered by Google App Engine
This is Rietveld 408576698