Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 827923007: Fix gdb pretty printing for content::SiteInstanceImpl. (Closed)

Created:
5 years, 11 months ago by lfg
Modified:
5 years, 11 months ago
Reviewers:
Jeffrey Yasskin
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix gdb pretty printing for content::SiteInstanceImpl. NOTRY=true Committed: https://crrev.com/9816cb6b5aa56466bc9888d47b4e8753313bd25f Cr-Commit-Position: refs/heads/master@{#311571}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M tools/gdb/gdb_chrome.py View 1 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
lfg
PTAL.
5 years, 11 months ago (2015-01-08 21:42:32 UTC) #2
Jeffrey Yasskin
lgtm either way. Thanks. https://codereview.chromium.org/827923007/diff/1/tools/gdb/gdb_chrome.py File tools/gdb/gdb_chrome.py (right): https://codereview.chromium.org/827923007/diff/1/tools/gdb/gdb_chrome.py#newcode286 tools/gdb/gdb_chrome.py:286: if self.val['g_render_process_host_factory_']: Since this is ...
5 years, 11 months ago (2015-01-14 00:41:45 UTC) #3
lfg
https://codereview.chromium.org/827923007/diff/1/tools/gdb/gdb_chrome.py File tools/gdb/gdb_chrome.py (right): https://codereview.chromium.org/827923007/diff/1/tools/gdb/gdb_chrome.py#newcode286 tools/gdb/gdb_chrome.py:286: if self.val['g_render_process_host_factory_']: On 2015/01/14 00:41:45, Jeffrey Yasskin wrote: > ...
5 years, 11 months ago (2015-01-14 23:31:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/827923007/20001
5 years, 11 months ago (2015-01-14 23:33:27 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-14 23:34:31 UTC) #7
commit-bot: I haz the power
5 years, 11 months ago (2015-01-14 23:35:35 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9816cb6b5aa56466bc9888d47b4e8753313bd25f
Cr-Commit-Position: refs/heads/master@{#311571}

Powered by Google App Engine
This is Rietveld 408576698