src/gpu/GrResourceCache2.cpp - Issue 827923006: Cap id size returned by GrScratchKey::GenerateResourceType

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/gpu/GrResourceCache2.cpp

Issue 827923006: Cap id size returned by GrScratchKey::GenerateResourceType (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/gpu/GrResourceCache2.cpp

diff --git a/src/gpu/GrResourceCache2.cpp b/src/gpu/GrResourceCache2.cpp

index ccfe382733fa94383c09bd48da8cef75bfe5a86b..1db96ec1cce8352ee468d95372b76b3df287576d 100644

--- a/src/gpu/GrResourceCache2.cpp

+++ b/src/gpu/GrResourceCache2.cpp

@@ -22,7 +22,7 @@ GrScratchKey::ResourceType GrScratchKey::GenerateResourceType() {

static int32_t gType = kInvalidResourceType + 1;

int32_t type = sk_atomic_inc(&gType);

- if (kInvalidResourceType == type) {

+ if (type > SK_MaxU16) {

SkFAIL("Too many Resource Types");

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »