testing/pdfium_embeddertest.cpp - Issue 827733006: Create first pdfium embedder test.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: testing/pdfium_embeddertest.cpp

Issue 827733006: Create first pdfium embedder test. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Add second simple test. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright (c) 2015 PDFium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "pdfium_test_embedder.h"

	6 #include "testing/gtest/include/gtest/gtest.h"

	7

	8 class PDFiumEmbeddertest : public PDFiumTestEmbedder {
	jam 2015/01/13 19:21:18 it's confusing having both PDFiumEmbeddertest and it's confusing having both PDFiumEmbeddertest and PDFiumTestEmbedder I would have thought that the test harness would be called PDFiumEmbedderTest (i.e. analogous to UnitTest or BrowserTest), or even just EmbedderTest (since pdfium is redundant in this repo). this class could then be called BasicTest or something similar
	9 };

	10

	11 TEST_F(PDFiumEmbeddertest, GetPageCount) {

	12 EXPECT_TRUE(OpenDocument("testing/resources/about_blank.pdf"));

	13 EXPECT_EQ(1, GetPageCount());

	14 }

	15

	16 TEST_F(PDFiumEmbeddertest, GetFirstPageNum) {

	17 EXPECT_TRUE(OpenDocument("testing/resources/about_blank.pdf"));

	18 EXPECT_EQ(0, GetFirstPageNum());

	19 }

OLD	NEW