Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 827733004: Change function signature of SkPDFObject::emitObject. (Closed)

Created:
5 years, 11 months ago by hal.canary
Modified:
5 years, 11 months ago
Reviewers:
djsollen
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Change function signature of SkPDFObject::emitObject. Replace virutal SkPDFObject::emitObject(s, c, true) with non-virtual SkPDFObject::emitIndirectObject(s, c), since none of the subclasses do (or should do) anything different. Replace object->emitObject(s, c, false) with object->emitObject(s, c) This is one step in simplifying the SkPDFObject interface to allow for the next step in refactoring. Committed: https://skia.googlesource.com/skia/+/4fc48af0d7bec93a911d32330f251386a8adec98

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -83 lines) Patch
M src/pdf/SkPDFDocument.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M src/pdf/SkPDFFont.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M src/pdf/SkPDFFontImpl.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/pdf/SkPDFGraphicState.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/pdf/SkPDFGraphicState.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M src/pdf/SkPDFPage.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/pdf/SkPDFStream.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/pdf/SkPDFStream.cpp View 1 chunk +3 lines, -7 lines 0 comments Download
M src/pdf/SkPDFTypes.h View 9 chunks +10 lines, -20 lines 0 comments Download
M src/pdf/SkPDFTypes.cpp View 9 chunks +14 lines, -38 lines 0 comments Download
M tests/PDFPrimitivesTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/827733004/1
5 years, 11 months ago (2015-01-12 17:49:33 UTC) #2
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 11 months ago (2015-01-12 17:49:34 UTC) #3
hal.canary
ptal
5 years, 11 months ago (2015-01-12 17:50:02 UTC) #6
djsollen
lgtm
5 years, 11 months ago (2015-01-12 18:03:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/827733004/1
5 years, 11 months ago (2015-01-12 18:07:43 UTC) #9
commit-bot: I haz the power
5 years, 11 months ago (2015-01-12 18:07:54 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/4fc48af0d7bec93a911d32330f251386a8adec98

Powered by Google App Engine
This is Rietveld 408576698