Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 82773002: Move some dependencies of ExtensionService down to extensions. (Closed)

Created:
7 years, 1 month ago by benwells
Modified:
7 years ago
Reviewers:
miket_OOO, sky
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, tfarina, dbeam+watch-ntp_chromium.org, pam+watch_chromium.org, oshima+watch_chromium.org, estade+watch_chromium.org, chromium-apps-reviews_chromium.org, native-client-reviews_googlegroups.com, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, pedrosimonetti+watch_chromium.org, yozhkin, Daniel Erat
Visibility:
Public.

Description

Move some dependencies of ExtensionService down to extensions. These files do not have any dependencies to the rest of chrome so can move down immediately. TBR=miket, sky BUG=298537 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=237299

Patch Set 1 #

Patch Set 2 : Upload again #

Patch Set 3 : rebase #

Patch Set 4 : Presubmit check fixed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -1201 lines) Patch
M chrome/browser/chrome_content_browser_client.cc View 1 2 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/device_local_account_external_policy_loader_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/device_local_account_management_policy_provider.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/developer_private/developer_private_api.cc View 1 2 3 4 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/management/management_api.cc View 1 2 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/management/management_apitest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/crx_installer.cc View 1 2 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_context_menu_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_context_menu_model.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_context_menu_model_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_installer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_protocols.cc View 1 2 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_service.h View 1 2 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_service.cc View 1 2 4 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_service_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_system.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_ui_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/external_policy_loader_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/external_provider_impl.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/extensions/external_provider_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/extensions/external_provider_interface.h View 1 chunk +0 lines, -98 lines 0 comments Download
M chrome/browser/extensions/install_verifier.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/installed_loader.cc View 2 chunks +1 line, -1 line 0 comments Download
D chrome/browser/extensions/management_policy.h View 1 chunk +0 lines, -141 lines 0 comments Download
D chrome/browser/extensions/management_policy.cc View 1 chunk +0 lines, -116 lines 0 comments Download
D chrome/browser/extensions/management_policy_unittest.cc View 1 chunk +0 lines, -211 lines 0 comments Download
M chrome/browser/extensions/standard_management_policy_provider.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/test_extension_system.cc View 1 2 2 chunks +1 line, -1 line 0 comments Download
D chrome/browser/extensions/test_management_policy.h View 1 chunk +0 lines, -65 lines 0 comments Download
D chrome/browser/extensions/test_management_policy.cc View 1 chunk +0 lines, -78 lines 0 comments Download
M chrome/browser/extensions/webstore_installer.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/webstore_installer.cc View 1 2 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/managed_mode/managed_user_service.h View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/nacl_host/nacl_browser_delegate_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profile_resetter/profile_resetter.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/app_list/app_list_controller_delegate.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/extensions/extension_settings_handler.cc View 1 2 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/ntp/app_launcher_handler.cc View 1 2 2 chunks +1 line, -1 line 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 2 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/chrome_common.gypi View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 6 chunks +4 lines, -4 lines 0 comments Download
M chrome/common/extensions/chrome_manifest_handlers.cc View 2 chunks +1 line, -1 line 0 comments Download
D chrome/common/extensions/manifest_handlers/shared_module_info.h View 1 chunk +0 lines, -71 lines 0 comments Download
D chrome/common/extensions/manifest_handlers/shared_module_info.cc View 1 chunk +0 lines, -227 lines 0 comments Download
D chrome/common/extensions/manifest_handlers/shared_module_manifest_unittest.cc View 1 chunk +0 lines, -120 lines 0 comments Download
M chrome/common/pepper_permission_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/DEPS View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + extensions/browser/external_provider_interface.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + extensions/browser/management_policy.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + extensions/browser/management_policy.cc View 1 chunk +1 line, -1 line 0 comments Download
A + extensions/browser/management_policy_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + extensions/browser/test_management_policy.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + extensions/browser/test_management_policy.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/DEPS View 1 chunk +8 lines, -0 lines 0 comments Download
A + extensions/common/manifest_handlers/shared_module_info.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + extensions/common/manifest_handlers/shared_module_info.cc View 1 chunk +1 line, -1 line 0 comments Download
A + extensions/common/manifest_handlers/shared_module_manifest_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/extensions.gyp View 3 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
benwells
7 years, 1 month ago (2013-11-22 13:15:43 UTC) #1
James Cook
On 2013/11/22 13:15:43, benwells wrote: Drive-by comment: I don't see the file additions in rietveld. ...
7 years, 1 month ago (2013-11-22 16:41:05 UTC) #2
miket_OOO
On 2013/11/22 16:41:05, James Cook wrote: > On 2013/11/22 13:15:43, benwells wrote: > > Drive-by ...
7 years, 1 month ago (2013-11-22 23:38:15 UTC) #3
benwells
Uploaded again
7 years, 1 month ago (2013-11-23 00:12:57 UTC) #4
benwells
miket -> tbr +tbr sky Thanks Mike, yeah this one is purely tools/git/move_source_file.py :)
7 years, 1 month ago (2013-11-23 01:22:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benwells@chromium.org/82773002/170001
7 years, 1 month ago (2013-11-23 01:25:13 UTC) #6
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=37800
7 years, 1 month ago (2013-11-23 01:47:19 UTC) #7
miket_OOO
lgtm
7 years ago (2013-11-25 19:13:37 UTC) #8
benwells
On 2013/11/25 19:13:37, miket wrote: > lgtm Been sherriffing so haven't had time to fix ...
7 years ago (2013-11-26 05:48:24 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benwells@chromium.org/82773002/710001
7 years ago (2013-11-26 06:58:32 UTC) #10
commit-bot: I haz the power
7 years ago (2013-11-26 10:37:48 UTC) #11
Message was sent while issue was closed.
Change committed as 237299

Powered by Google App Engine
This is Rietveld 408576698