Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 827723002: Reland: Templatize visitor arguments for TraceTrait mark and trace methods. (Closed)

Created:
5 years, 12 months ago by kouhei (in TOK)
Modified:
5 years, 11 months ago
Reviewers:
oilpan-reviews, haraken
CC:
blink-reviews, Mads Ager (chromium), oilpan-reviews, blink-reviews-wtf_chromium.org, aandrey+blink_chromium.org, kouhei+heap_chromium.org, Mikhail
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Reland: Templatize visitor arguments for TraceTrait mark and trace methods. Windows build issues are fixed. > Templatize visitor arguments for TraceTrait mark and trace methods. > > This CL replaces Visitor* in TraceTrait<T>::{mark,trace} methods arguments > to template parameter VisitorDispatcher. > > This is to prepare for InlinedGlobalMarkingVisitor implementaion, so that > those methods can also be used to dispatch > TraceTrait<T>::mark(InlinedGlobalMarkingVisitor) in addition to the current > TraceTrait<T>::mark(Visitor*) usage. TBR=jochen@chromium.org BUG=420515 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187837

Patch Set 1 #

Patch Set 2 : maybefix #

Patch Set 3 : synerr #

Patch Set 4 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -49 lines) Patch
M Source/platform/heap/Heap.h View 1 2 3 17 chunks +53 lines, -24 lines 0 comments Download
M Source/platform/heap/HeapTest.cpp View 1 2 3 3 chunks +4 lines, -1 line 0 comments Download
M Source/platform/heap/Visitor.h View 1 2 3 5 chunks +12 lines, -7 lines 0 comments Download
M Source/wtf/Deque.h View 1 2 3 3 chunks +6 lines, -5 lines 0 comments Download
M Source/wtf/HashTable.h View 3 chunks +4 lines, -3 lines 0 comments Download
M Source/wtf/TypeTraits.h View 1 2 2 chunks +29 lines, -6 lines 0 comments Download
M Source/wtf/Vector.h View 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
kouhei (in TOK)
PTAL.
5 years, 11 months ago (2015-01-05 01:29:20 UTC) #2
haraken
rubberstamp LGTM
5 years, 11 months ago (2015-01-05 01:34:19 UTC) #3
kouhei (in TOK)
win_blink_oilpan_dbg passed compile. Let me send this to CQ
5 years, 11 months ago (2015-01-05 02:53:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/827723002/60001
5 years, 11 months ago (2015-01-05 02:54:16 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/23438)
5 years, 11 months ago (2015-01-05 02:59:42 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/827723002/60001
5 years, 11 months ago (2015-01-05 03:01:19 UTC) #10
commit-bot: I haz the power
5 years, 11 months ago (2015-01-05 03:04:23 UTC) #11
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187837

Powered by Google App Engine
This is Rietveld 408576698