Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Issue 82763004: Clean up incorrect V8_DEPRECATION macro usage and enable deprecatitions (Closed)

Created:
7 years, 1 month ago by jochen (gone - plz use gerrit)
Modified:
7 years, 1 month ago
CC:
v8-dev, Paweł Hajdan Jr.
Visibility:
Public.

Description

Clean up incorrect V8_DEPRECATION macro usage and enable deprecatitions We turn the default for standalone builds on, however, I added overrides to all targets to turn it locally off again. In follow up CLs, I'll clean up one target at a time. BUG=v8:3023 R=dcarney@chromium.org, machenbach@chromium.org LOG=n Committed: https://code.google.com/p/v8/source/detail?r=18002

Patch Set 1 : updates #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -8 lines) Patch
M build/standalone.gypi View 1 chunk +1 line, -0 lines 2 comments Download
M include/v8.h View 8 chunks +8 lines, -8 lines 0 comments Download
M samples/samples.gyp View 1 chunk +4 lines, -0 lines 0 comments Download
M src/d8.gyp View 1 chunk +6 lines, -0 lines 0 comments Download
M test/cctest/cctest.gyp View 1 chunk +6 lines, -0 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jochen (gone - plz use gerrit)
plz review
7 years, 1 month ago (2013-11-22 09:37:33 UTC) #1
dcarney
lgtm
7 years, 1 month ago (2013-11-22 09:45:07 UTC) #2
Michael Achenbach
https://codereview.chromium.org/82763004/diff/90001/build/standalone.gypi File build/standalone.gypi (right): https://codereview.chromium.org/82763004/diff/90001/build/standalone.gypi#newcode40 build/standalone.gypi:40: 'v8_deprecation_warnings': 1, Does that not need a % to ...
7 years, 1 month ago (2013-11-22 10:14:12 UTC) #3
jochen (gone - plz use gerrit)
https://codereview.chromium.org/82763004/diff/90001/build/standalone.gypi File build/standalone.gypi (right): https://codereview.chromium.org/82763004/diff/90001/build/standalone.gypi#newcode40 build/standalone.gypi:40: 'v8_deprecation_warnings': 1, On 2013/11/22 10:14:13, machenbach wrote: > Does ...
7 years, 1 month ago (2013-11-22 10:19:18 UTC) #4
Michael Achenbach
lgtm
7 years, 1 month ago (2013-11-22 10:54:23 UTC) #5
jochen (gone - plz use gerrit)
7 years, 1 month ago (2013-11-22 10:58:03 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 manually as r18002 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698