Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Issue 827523004: [sql] Enable HAVE_USLEEP for more platforms. (Closed)

Created:
5 years, 11 months ago by Scott Hess - ex-Googler
Modified:
5 years, 11 months ago
Reviewers:
michaeln
CC:
chromium-reviews, Yaron
Base URL:
http://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[sql] Enable HAVE_USLEEP for more platforms. HAVE_USLEEP affects SQLite's sleep implementation, which is used when SQLite waits for a lock to clear. Browser databases are generally uncontended, but this case could happen for WebDatabase in the renderer. BUG=none Committed: https://crrev.com/156733dbbc0068b30c0c884c78a59679c755df13 Cr-Commit-Position: refs/heads/master@{#312460}

Patch Set 1 #

Patch Set 2 : Tweak comments. #

Patch Set 3 : rebase to trunk #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -2 lines) Patch
M sql/sqlite_features_unittest.cc View 1 1 chunk +17 lines, -0 lines 0 comments Download
M third_party/sqlite/BUILD.gn View 1 2 chunks +9 lines, -1 line 0 comments Download
M third_party/sqlite/sqlite.gyp View 2 chunks +10 lines, -1 line 0 comments Download

Messages

Total messages: 18 (7 generated)
Scott Hess - ex-Googler
Michael, you may remember this from the Gears days. I don't think it actually matters ...
5 years, 11 months ago (2015-01-13 18:52:30 UTC) #2
Scott Hess - ex-Googler
Michael, you may remember this from the Gears days. I don't think it actually matters ...
5 years, 11 months ago (2015-01-17 01:35:50 UTC) #4
michaeln
lgtm
5 years, 11 months ago (2015-01-20 22:20:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/827523004/20001
5 years, 11 months ago (2015-01-21 00:57:44 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel/builds/27035)
5 years, 11 months ago (2015-01-21 02:34:35 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/827523004/20001
5 years, 11 months ago (2015-01-21 04:40:46 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel/builds/27035)
5 years, 11 months ago (2015-01-21 04:42:45 UTC) #13
Scott Hess - ex-Googler
On 2015/01/21 04:42:45, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
5 years, 11 months ago (2015-01-21 18:49:13 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/827523004/40001
5 years, 11 months ago (2015-01-21 20:48:21 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 11 months ago (2015-01-21 21:52:57 UTC) #17
commit-bot: I haz the power
5 years, 11 months ago (2015-01-21 21:53:39 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/156733dbbc0068b30c0c884c78a59679c755df13
Cr-Commit-Position: refs/heads/master@{#312460}

Powered by Google App Engine
This is Rietveld 408576698