Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(840)

Issue 8275013: Pepper: Add a C++ wrapper for the trusted file chooser. (Closed)

Created:
9 years, 2 months ago by viettrungluu
Modified:
9 years, 2 months ago
Reviewers:
bbudge, piman
CC:
chromium-reviews
Visibility:
Public.

Description

Pepper: Add a C++ wrapper for the trusted file chooser. This makes it easy (for trusted Pepper plugins) to opt for showing a file chooser while avoiding the user-gesture check. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=105392

Patch Set 1 #

Patch Set 2 : x #

Total comments: 2

Patch Set 3 : update copyright #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -3 lines) Patch
M ppapi/cpp/dev/file_chooser_dev.h View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
A ppapi/cpp/trusted/file_chooser_trusted.h View 1 chunk +38 lines, -0 lines 0 comments Download
A ppapi/cpp/trusted/file_chooser_trusted.cc View 1 1 chunk +53 lines, -0 lines 0 comments Download
M ppapi/ppapi_cpp.gypi View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
viettrungluu
9 years, 2 months ago (2011-10-13 20:53:54 UTC) #1
bbudge
LGTM.
9 years, 2 months ago (2011-10-13 21:39:50 UTC) #2
bbudge
Whoops, too quick. A comment. http://codereview.chromium.org/8275013/diff/1005/ppapi/cpp/dev/file_chooser_dev.h File ppapi/cpp/dev/file_chooser_dev.h (right): http://codereview.chromium.org/8275013/diff/1005/ppapi/cpp/dev/file_chooser_dev.h#newcode68 ppapi/cpp/dev/file_chooser_dev.h:68: virtual FileRef GetNextChosenFile() const; ...
9 years, 2 months ago (2011-10-13 21:42:23 UTC) #3
viettrungluu
http://codereview.chromium.org/8275013/diff/1005/ppapi/cpp/dev/file_chooser_dev.h File ppapi/cpp/dev/file_chooser_dev.h (right): http://codereview.chromium.org/8275013/diff/1005/ppapi/cpp/dev/file_chooser_dev.h#newcode68 ppapi/cpp/dev/file_chooser_dev.h:68: virtual FileRef GetNextChosenFile() const; On 2011/10/13 21:42:23, bbudge1 wrote: ...
9 years, 2 months ago (2011-10-13 21:47:56 UTC) #4
bbudge
On 2011/10/13 21:47:56, viettrungluu wrote: > http://codereview.chromium.org/8275013/diff/1005/ppapi/cpp/dev/file_chooser_dev.h > File ppapi/cpp/dev/file_chooser_dev.h (right): > > http://codereview.chromium.org/8275013/diff/1005/ppapi/cpp/dev/file_chooser_dev.h#newcode68 > ...
9 years, 2 months ago (2011-10-13 22:08:11 UTC) #5
piman
9 years, 2 months ago (2011-10-13 22:26:59 UTC) #6
lgtm

Powered by Google App Engine
This is Rietveld 408576698