Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 827443003: Add querying supported formats to V4L2 VEA (Closed)

Created:
5 years, 11 months ago by henryhsu
Modified:
5 years, 11 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, creis+watch_chromium.org, nkostylev+watch_chromium.org, posciak+watch_chromium.org, wjia+watch_chromium.org, dzhioev+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, oshima+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, piman+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add querying supported formats to V4L2 VEA This switch only applied on nyan and peach series. Modify GetSupportedProfiles in V4L2 video encode accelerator to query all supported formats. BUG=350197 TEST=manually test on peach_pit and nyan_big, make sure GetSupportedProfiles include H264 and VP8 by querying ENUM_FMT. Committed: https://crrev.com/55b23c708f0ce6a0d951fde610e06cde59bcec58 Cr-Commit-Position: refs/heads/master@{#310051}

Patch Set 1 #

Total comments: 1

Patch Set 2 : fix nit #

Patch Set 3 : rebase #

Total comments: 1

Patch Set 4 : fix nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -24 lines) Patch
M chrome/browser/chromeos/login/chrome_restart_request.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/gpu/gpu_process_host.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M content/common/gpu/media/v4l2_video_encode_accelerator.cc View 1 2 3 1 chunk +16 lines, -12 lines 0 comments Download
M content/public/common/content_switches.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/content_switches.cc View 1 2 2 chunks +1 line, -4 lines 0 comments Download
M content/renderer/media/rtc_video_encoder_factory.cc View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
henryhsu
PTAL
5 years, 11 months ago (2015-01-01 09:16:04 UTC) #2
Pawel Osciak
lgtm % nit Please change the CL subject to say that this adds querying supported ...
5 years, 11 months ago (2015-01-01 14:14:37 UTC) #3
Pawel Osciak
piman@: ptal
5 years, 11 months ago (2015-01-01 14:15:38 UTC) #5
piman
LGTM+nit https://codereview.chromium.org/827443003/diff/40001/content/common/gpu/media/v4l2_video_encode_accelerator.cc File content/common/gpu/media/v4l2_video_encode_accelerator.cc (right): https://codereview.chromium.org/827443003/diff/40001/content/common/gpu/media/v4l2_video_encode_accelerator.cc#newcode296 content/common/gpu/media/v4l2_video_encode_accelerator.cc:296: case V4L2_PIX_FMT_H264: nit: indent (run git cl format?)
5 years, 11 months ago (2015-01-05 23:36:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/827443003/60001
5 years, 11 months ago (2015-01-06 02:34:44 UTC) #8
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 11 months ago (2015-01-06 04:33:30 UTC) #9
commit-bot: I haz the power
5 years, 11 months ago (2015-01-06 04:34:36 UTC) #10
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/55b23c708f0ce6a0d951fde610e06cde59bcec58
Cr-Commit-Position: refs/heads/master@{#310051}

Powered by Google App Engine
This is Rietveld 408576698