Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 827433002: Resolve two USB transfer handling regressions. (Closed)

Created:
5 years, 12 months ago by Reilly Grant (use Gerrit)
Modified:
5 years, 12 months ago
Reviewers:
rpaquay
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Resolve two USB transfer handling regressions. Two regressions were introduced by https://crrev.com/30c6291b559f48df49. The first was that the wValue and wIndex fields of control transfers were passed as uint8s, truncating these normally 16-bit values. The second was that the number of packets of an isochronous transfer was no longer passed to libusb_alloc_transfer. BUG=443107 Committed: https://crrev.com/75c69eaf605093e4654ff16ac77b93630165ab61 Cr-Commit-Position: refs/heads/master@{#309598}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -5 lines) Patch
M device/usb/usb_device_handle_impl.cc View 6 chunks +9 lines, -5 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
Reilly Grant (use Gerrit)
Renaud, please take a look at this patch.
5 years, 12 months ago (2014-12-23 20:45:54 UTC) #2
rpaquay
lgtm
5 years, 12 months ago (2014-12-23 21:24:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/827433002/1
5 years, 12 months ago (2014-12-23 21:27:45 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_dbg/builds/28641)
5 years, 12 months ago (2014-12-23 21:35:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/827433002/1
5 years, 12 months ago (2014-12-23 23:29:56 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_dbg/builds/28713)
5 years, 12 months ago (2014-12-23 23:39:24 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/827433002/1
5 years, 12 months ago (2014-12-24 01:26:25 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 12 months ago (2014-12-24 01:27:41 UTC) #14
commit-bot: I haz the power
5 years, 12 months ago (2014-12-24 01:28:22 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/75c69eaf605093e4654ff16ac77b93630165ab61
Cr-Commit-Position: refs/heads/master@{#309598}

Powered by Google App Engine
This is Rietveld 408576698