Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issue 8274031: Merge r9430, r9433 and r9508 into 3.5 branch. (Closed)

Created:
9 years, 2 months ago by mnaganov (inactive)
Modified:
9 years, 2 months ago
Reviewers:
danno
CC:
v8-dev
Visibility:
Public.

Description

Merge r9430, r9433 and r9508 into 3.5 branch. r9430 Add v8::HeapGraphNode::GetHeapValue method. r9433 Fix race in CpuProfiler::StopProcessor / CpuProfiler::TickSampleEvent. r9508 Fix incorrect function name inference in case of assignment / global assignment. BUG=webkit:61179, v8:1700, v8:1732 Committed: http://code.google.com/p/v8/source/detail?r=9623

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+184 lines, -37 lines) Patch
M include/v8-profiler.h View 1 chunk +6 lines, -0 lines 0 comments Download
M src/api.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M src/cpu-profiler.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/func-name-inferrer.h View 1 chunk +6 lines, -0 lines 0 comments Download
M src/parser.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M src/profile-generator.h View 2 chunks +3 lines, -0 lines 0 comments Download
M src/profile-generator.cc View 1 3 chunks +25 lines, -2 lines 0 comments Download
M src/version.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-func-name-inference.cc View 1 chunk +39 lines, -0 lines 0 comments Download
M test/cctest/test-heap-profiler.cc View 25 chunks +89 lines, -33 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
mnaganov (inactive)
9 years, 2 months ago (2011-10-14 08:53:09 UTC) #1
mnaganov (inactive)
On 2011/10/14 08:53:09, Mikhail Naganov (Chromium) wrote: Hold on a bit. I need to resolve ...
9 years, 2 months ago (2011-10-14 08:55:01 UTC) #2
mnaganov (inactive)
On 2011/10/14 08:55:01, Mikhail Naganov (Chromium) wrote: > On 2011/10/14 08:53:09, Mikhail Naganov (Chromium) wrote: ...
9 years, 2 months ago (2011-10-14 08:56:21 UTC) #3
danno
9 years, 2 months ago (2011-10-14 09:21:48 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698