Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 8273037: Merge r9430, r9433, r9508 and 9615 into 3.6 branch. (Closed)

Created:
9 years, 2 months ago by danno
Modified:
9 years, 2 months ago
CC:
v8-dev
Visibility:
Public.

Description

Merge r9430, r9433, r9508 and 9615 into 3.6 branch. r9430 Add v8::HeapGraphNode::GetHeapValue method. r9433 Fix race in CpuProfiler::StopProcessor / CpuProfiler::TickSampleEvent. r9508 Fix incorrect function name inference in case of assignment / global assignment. r9615 Add missing hole check to FixedDoubleArray::Initialize BUG=webkit:61179, v8:1700, v8:17321 Committed: http://code.google.com/p/v8/source/detail?r=9637

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+190 lines, -39 lines) Patch
M include/v8-profiler.h View 1 chunk +6 lines, -0 lines 0 comments Download
M src/api.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M src/cpu-profiler.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/func-name-inferrer.h View 1 chunk +6 lines, -0 lines 0 comments Download
M src/objects-inl.h View 1 1 chunk +5 lines, -1 line 0 comments Download
M src/parser.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M src/profile-generator.h View 2 chunks +3 lines, -0 lines 0 comments Download
M src/profile-generator.cc View 3 chunks +25 lines, -2 lines 0 comments Download
M src/version.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/test-func-name-inference.cc View 1 chunk +39 lines, -0 lines 0 comments Download
M test/cctest/test-heap-profiler.cc View 25 chunks +89 lines, -33 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
danno
These are post new GC cherry-picks that need to be merged back to 3.6. Please ...
9 years, 2 months ago (2011-10-14 12:28:09 UTC) #1
mnaganov (inactive)
On 2011/10/14 12:28:09, danno wrote: > These are post new GC cherry-picks that need to ...
9 years, 2 months ago (2011-10-14 12:31:51 UTC) #2
Mads Ager (chromium)
lgtm
9 years, 2 months ago (2011-10-14 12:32:01 UTC) #3
mnaganov (inactive)
On 2011/10/14 12:32:01, Mads Sig Ager wrote: > lgtm Oh. But I don't see r9615 ...
9 years, 2 months ago (2011-10-14 12:33:00 UTC) #4
Yang
9 years, 2 months ago (2011-10-14 12:43:03 UTC) #5
On 2011/10/14 12:33:00, Mikhail Naganov (Chromium) wrote:
> On 2011/10/14 12:32:01, Mads Sig Ager wrote:
> > lgtm
> 
> Oh. But I don't see r9615 here. It should change objects-inl.h

lgtm.

Powered by Google App Engine
This is Rietveld 408576698