chrome/browser/chromeos/app_mode/kiosk_app_data.h - Issue 827293003: Update {virtual,override,final} to follow C++11 style in chrome/browser/chromeos/app_mode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/app_mode/kiosk_app_data.h

Issue 827293003: Update {virtual,override,final} to follow C++11 style in chrome/browser/chromeos/app_mode. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comment Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/app_mode/certificate_manager_dialog.h ('k') | chrome/browser/chromeos/app_mode/kiosk_app_data.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/app_mode/kiosk_app_data.h

diff --git a/chrome/browser/chromeos/app_mode/kiosk_app_data.h b/chrome/browser/chromeos/app_mode/kiosk_app_data.h

index 7b3a9ee7e247fc596049ffc629fba0ee409dc117..b429020e0a47104ba445820c6c48d972aedd0f54 100644

--- a/chrome/browser/chromeos/app_mode/kiosk_app_data.h

+++ b/chrome/browser/chromeos/app_mode/kiosk_app_data.h

@@ -54,7 +54,7 @@ class KioskAppData : public base::SupportsWeakPtr<KioskAppData>,

const std::string& app_id,

const std::string& user_id,

const GURL& update_url);

- virtual ~KioskAppData();

+ ~KioskAppData() override;

// Loads app data from cache. If there is no cached data, fetches it

// from web store.

@@ -113,11 +113,10 @@ class KioskAppData : public base::SupportsWeakPtr<KioskAppData>,

void StartFetch();

// extensions::WebstoreDataFetcherDelegate overrides:

- virtual void OnWebstoreRequestFailure() override;

- virtual void OnWebstoreResponseParseSuccess(

+ void OnWebstoreRequestFailure() override;

+ void OnWebstoreResponseParseSuccess(

scoped_ptr<base::DictionaryValue> webstore_data) override;

- virtual void OnWebstoreResponseParseFailure(

- const std::string& error) override;

+ void OnWebstoreResponseParseFailure(const std::string& error) override;

// Helper function for testing for the existence of |key| in