Turn on UseLibraryDependencyInputs for browser_tests to enable incremental linking.

Enable incremental linking for browser_tests on Windows.

This is based on scottmg's https://codereview.chromium.org/25377002/.

BUG=308773
R=scottmg@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=236855

[jam, 2013-11-22 18:28:10]

I didn't get trybot failures for your original change, but I applied fixes
anyways for the errors you got. Something here is not deterministic.

I'm in favor of landing this with green trybots and watching the tree. It's so
painful without this!

[scottmg, 2013-11-22 18:31:53]

lgtm if after you've put in the ULDI block the "win" trybot is green.

https://codereview.chromium.org/82713004/diff/50002/chrome/browser/ui/views/f...
File
chrome/browser/ui/views/frame/browser_window_property_manager_browsertest_win.cc
(right):

https://codereview.chromium.org/82713004/diff/50002/chrome/browser/ui/views/f...
chrome/browser/ui/views/frame/browser_window_property_manager_browsertest_win.cc:29:
#include "content/public/test/test_utils.h"
there was a few of these before... not sure how that happens!

https://codereview.chromium.org/82713004/diff/50002/chrome/chrome_tests.gypi
File chrome/chrome_tests.gypi (right):

https://codereview.chromium.org/82713004/diff/50002/chrome/chrome_tests.gypi#...
chrome/chrome_tests.gypi:968: 'win_use_external_manifest': 1,
this isn't enough to turn on incremental, you need the other block from here too

https://codereview.chromium.org/25377002/diff/1/chrome/chrome_tests.gypi

[jam, 2013-11-22 19:19:18]

https://codereview.chromium.org/82713004/diff/50002/chrome/browser/ui/views/f...
File
chrome/browser/ui/views/frame/browser_window_property_manager_browsertest_win.cc
(right):

https://codereview.chromium.org/82713004/diff/50002/chrome/browser/ui/views/f...
chrome/browser/ui/views/frame/browser_window_property_manager_browsertest_win.cc:29:
#include "content/public/test/test_utils.h"
On 2013/11/22 18:31:53, scottmg wrote:
> there was a few of these before... not sure how that happens!

yeah no idea, I had gone through the rest of the code using cs to see if there
are any others, but I didn't find any

https://codereview.chromium.org/82713004/diff/50002/chrome/chrome_tests.gypi
File chrome/chrome_tests.gypi (right):

https://codereview.chromium.org/82713004/diff/50002/chrome/chrome_tests.gypi#...
chrome/chrome_tests.gypi:968: 'win_use_external_manifest': 1,
On 2013/11/22 18:31:53, scottmg wrote:
> this isn't enough to turn on incremental, you need the other block from here
too
> 
> https://codereview.chromium.org/25377002/diff/1/chrome/chrome_tests.gypi

ah!, maybe that'll help find other problems

[scottmg, 2013-11-22 19:24:50]

https://codereview.chromium.org/82713004/diff/490001/chrome/chrome_tests.gypi
File chrome/chrome_tests.gypi (right):

https://codereview.chromium.org/82713004/diff/490001/chrome/chrome_tests.gypi...
chrome/chrome_tests.gypi:1677: 'msvs_settings': {
sorry, i screwed this up in the other CL, but i don't think this needs/should be
in a disable_nacl==0 block, it can just go at the top level of the browser_tests
target

[jam, 2013-11-22 20:28:44]

https://codereview.chromium.org/82713004/diff/490001/chrome/chrome_tests.gypi
File chrome/chrome_tests.gypi (right):

https://codereview.chromium.org/82713004/diff/490001/chrome/chrome_tests.gypi...
chrome/chrome_tests.gypi:1677: 'msvs_settings': {
On 2013/11/22 19:24:50, scottmg wrote:
> sorry, i screwed this up in the other CL, but i don't think this needs/should
be
> in a disable_nacl==0 block, it can just go at the top level of the
browser_tests
> target

my bad for not looking closely :)

[scottmg, 2013-11-22 23:08:43]

Nice, thanks!