content/public/android/javatests/src/org/chromium/content/browser/JavaBridgeCoercionTest.java - Issue 827123006: Revert of Reverting due to Android builders breakage. Subsequent fixes did not fix.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/javatests/src/org/chromium/content/browser/JavaBridgeCoercionTest.java

Issue 827123006: Revert of Reverting due to Android builders breakage. Subsequent fixes did not fix. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/public/android/javatests/src/org/chromium/content/browser/JavaBridgeChildFrameTest.java ('k') | content/public/android/javatests/src/org/chromium/content/browser/JavaBridgeFieldsTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/javatests/src/org/chromium/content/browser/JavaBridgeCoercionTest.java

diff --git a/content/public/android/javatests/src/org/chromium/content/browser/JavaBridgeCoercionTest.java b/content/public/android/javatests/src/org/chromium/content/browser/JavaBridgeCoercionTest.java

index bc16a072864dfe0469d5afe8706e40b4f950a811..aaf59abb1cf3d183db24782cea2083685f0cdd67 100644

--- a/content/public/android/javatests/src/org/chromium/content/browser/JavaBridgeCoercionTest.java

+++ b/content/public/android/javatests/src/org/chromium/content/browser/JavaBridgeCoercionTest.java

@@ -6,6 +6,7 @@

import android.test.suitebuilder.annotation.SmallTest;

+import org.chromium.base.annotations.SuppressFBWarnings;

import org.chromium.base.test.util.Feature;

/**

@@ -21,6 +22,7 @@

* break backwards-compatibility. See b/4408210.

public class JavaBridgeCoercionTest extends JavaBridgeTestBase {

+ @SuppressFBWarnings("CHROMIUM_SYNCHRONIZED_METHOD")

private class TestObject extends Controller {

private Object mObjectInstance;

private CustomType mCustomTypeInstance;

@@ -153,6 +155,7 @@

private TestObject mTestObject;

+ @SuppressFBWarnings("CHROMIUM_SYNCHRONIZED_METHOD")

private class TestController extends Controller {

private boolean mBooleanValue;