Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 827123004: The Certificate Web UI incorrectly formats the issued and expires dates. (Closed)

Created:
5 years, 11 months ago by jww
Modified:
5 years, 10 months ago
Reviewers:
danakj, James Hawkins
CC:
chromium-reviews, erikwright+watch_chromium.org, jshin+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

The Certificate Web UI incorrectly formats the issued and expires dates. The Web UI incorrectly states that the issued and expires dates for certificates is in UTC, when in fact it's in local time. Additionally, it appends UTC in a non-internationalized way. This patch fixes both issues by adding a new time_formatting.h utility function to produce a formatted time string with the local time zone appended. BUG=426909 Committed: https://crrev.com/62c6b3e4d72f287ff007895052e5166c6ccd79e0 Cr-Commit-Position: refs/heads/master@{#315240}

Patch Set 1 #

Patch Set 2 : Added unit tests #

Patch Set 3 : Rebase on ToT #

Patch Set 4 : Fix to unit test #

Patch Set 5 : Formatting #

Patch Set 6 : Undo accidental password_autofill_agent_browsertest change #

Patch Set 7 : Rebase on ToT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -9 lines) Patch
M base/i18n/time_formatting.h View 1 chunk +5 lines, -0 lines 0 comments Download
M base/i18n/time_formatting.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M base/i18n/time_formatting_unittest.cc View 1 2 3 4 4 chunks +20 lines, -0 lines 0 comments Download
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/certificate_viewer_webui.cc View 1 chunk +4 lines, -6 lines 0 comments Download

Messages

Total messages: 18 (6 generated)
jww
danakj@chromium.org: You were suggested as a good person to take a look at the base/ ...
5 years, 11 months ago (2015-01-15 01:44:23 UTC) #2
James Hawkins
I'm going to wait on the base/ review. My current understanding of the policy around ...
5 years, 11 months ago (2015-01-15 19:34:02 UTC) #3
danakj
can you add a unit test to demonstrate this function works? then lgtm
5 years, 10 months ago (2015-01-30 18:50:09 UTC) #4
jww
Unit test added. Thanks! jhawkins@, would you mind taking a look now that base/ is ...
5 years, 10 months ago (2015-02-02 15:09:36 UTC) #5
James Hawkins
lgtm
5 years, 10 months ago (2015-02-02 16:21:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/827123004/40001
5 years, 10 months ago (2015-02-02 16:41:25 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_tests_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tests_recipe/builds/51005)
5 years, 10 months ago (2015-02-02 18:45:40 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/827123004/80001
5 years, 10 months ago (2015-02-08 07:55:16 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/22731)
5 years, 10 months ago (2015-02-08 09:11:56 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/827123004/120001
5 years, 10 months ago (2015-02-08 17:47:08 UTC) #16
commit-bot: I haz the power
Committed patchset #7 (id:120001)
5 years, 10 months ago (2015-02-08 19:35:32 UTC) #17
commit-bot: I haz the power
5 years, 10 months ago (2015-02-08 19:36:10 UTC) #18
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/62c6b3e4d72f287ff007895052e5166c6ccd79e0
Cr-Commit-Position: refs/heads/master@{#315240}

Powered by Google App Engine
This is Rietveld 408576698