clang/win: Fix a few warnings/errors.

clang/win: Fix a few warnings/errors.

Add throw() declarations to fix clang compile errors and match the declarations in the MS SDK.

This is a followup to https://codereview.chromium.org/447513002

Also, cfree is deprecated and certainly isn't available on Windows, so removing the code.

BUG=82385
Committed: https://crrev.com/b712af8a5f27641efdb337e58390ceefe4cd07de
Cr-Commit-Position: refs/heads/master@{#312048}

[Will Harris, 2015-01-16 23:25:22]

wfh@chromium.org changed reviewers:
+ cpu@chromium.org

[Will Harris, 2015-01-16 23:25:23]

clang fix

[Will Harris, 2015-01-16 23:32:47]

wfh@chromium.org changed reviewers:
- cpu@chromium.org

[Will Harris, 2015-01-16 23:33:23]

wfh@chromium.org changed reviewers:
+ cpu@chromium.org

[Nico, 2015-01-16 23:36:23]

thakis@chromium.org changed reviewers:
+ thakis@chromium.org

[Nico, 2015-01-16 23:36:23]

Thanks!

Huh, https://codereview.chromium.org/447513002 added these to fix this warning;
you're removing them to fix the warning.

When I added them, it was to fix:

..\..\base\allocator/generic_allocators.cc(31,6) :  warning(clang): function
previously declared with an implicit exception specification redeclared with an
explicit exception specification [-Wimplicit-exception-spec-mismatch]
void operator delete(void* p) throw() {
     ^
E:\b\depot_tools\win_toolchain\vs2013_files\win8sdk\bin\..\..\VC\include\new(52,16)
:  note(clang): previous declaration is here
void __CRTDECL operator delete(void *) _THROW0();
               ^


You're fixing:

..\..\base\allocator/generic_allocators.cc(31,6) :  warning(clang): function
previously declared with an explicit exception specification redeclared with an
implicit exception specification [-Wimplicit-exception-spec-mismatch]
void operator delete(void* p) {
     ^

pointing at

C:\b\depot_tools\win_toolchain\vs2013_files\win8sdk\bin\..\..\VC\include\new.h(96,16)


Did the header files change? Did the _HAS_EXCEPTIONS define that these
translation units see change?

[Will Harris, 2015-01-16 23:53:09]

On 2015/01/16 23:36:23, Nico wrote:
> Thanks!
> 
> Huh, https://codereview.chromium.org/447513002 added these to fix this
warning;
> you're removing them to fix the warning.
> 
> When I added them, it was to fix:
> 
> ..\..\base\allocator/generic_allocators.cc(31,6) :  warning(clang): function
> previously declared with an implicit exception specification redeclared with
an
> explicit exception specification [-Wimplicit-exception-spec-mismatch]
> void operator delete(void* p) throw() {
>      ^
>
E:\b\depot_tools\win_toolchain\vs2013_files\win8sdk\bin\..\..\VC\include\new(52,16)
> :  note(clang): previous declaration is here
> void __CRTDECL operator delete(void *) _THROW0();
>                ^
> 
> 
> You're fixing:
> 
> ..\..\base\allocator/generic_allocators.cc(31,6) :  warning(clang): function
> previously declared with an explicit exception specification redeclared with
an
> implicit exception specification [-Wimplicit-exception-spec-mismatch]
> void operator delete(void* p) {
>      ^
> 
> pointing at
> 
>
C:\b\depot_tools\win_toolchain\vs2013_files\win8sdk\bin\..\..\VC\include\new.h(96,16)
> 
> 
> Did the header files change? Did the _HAS_EXCEPTIONS define that these
> translation units see change?

one is <new> and one is <new.h>  I can investigate which we actually need here.

[cpu_(ooo_6.6-7.5), 2015-01-17 00:28:48]

lgtm on my side

[Will Harris, 2015-01-18 06:49:05]

On 2015/01/17 00:28:48, cpu wrote:
> lgtm on my side

this definitely needs to be <new.h> (not <new>) since we need
_query_new_handler, so I'll commit as-is.

[Will Harris, 2015-01-18 06:49:10]

The CQ bit was checked by wfh@chromium.org

[commit-bot: I haz the power, 2015-01-18 06:49:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/827013006/1

[commit-bot: I haz the power, 2015-01-18 06:54:59]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-01-18 06:56:08]

Patchset 1 (id:??) landed as
https://crrev.com/b712af8a5f27641efdb337e58390ceefe4cd07de
Cr-Commit-Position: refs/heads/master@{#312048}