media/base/renderer.h - Issue 827013005: Avoid double task trampoline for Pipeline state transitions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/base/renderer.h

Issue 827013005: Avoid double task trampoline for Pipeline state transitions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Cleanup. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: media/base/renderer.h

diff --git a/media/base/renderer.h b/media/base/renderer.h

index f909350a7d4e0c9f62168680f46152546e21b173..206a8d3b3d5b985a0f27ee9dd89312c8742e0e6c 100644

--- a/media/base/renderer.h

+++ b/media/base/renderer.h

@@ -30,8 +30,9 @@ class MEDIA_EXPORT Renderer {

// Initializes the Renderer with |demuxer_stream_provider|, executing

// |init_cb| upon completion. If initialization failed, fires |error_cb|

- // before |init_cb|. |demuxer_stream_provider| must be valid throughout the

- // lifetime of the Renderer object.

+ // before |init_cb|. |demuxer_stream_provider| must be valid throughout the

+ // lifetime of the Renderer object. |init_cb| must only be run after this

+ // method has returned.

// Permanent callbacks:

// - |statistics_cb|: Executed periodically with rendering statistics.

« no previous file with comments | « media/base/pipeline_unittest.cc ('k') | media/filters/chunk_demuxer.cc » ('j') | no next file with comments »