Linux: Change ShellIntegration code to use GetXDGDirectory().

chrome/browser/shell_integration_linux_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/shell_integration_linux.h"
 
 #include <algorithm>
 #include <cstdlib>
 #include <map>
 #include <vector>
@@ skipping 81 matching lines @@
 
 }  // namespace
 
 TEST(ShellIntegrationTest, GetDataWriteLocation) {
   base::MessageLoop message_loop;
   content::TestBrowserThread file_thread(BrowserThread::FILE, &message_loop);
 
   // Test that it returns $XDG_DATA_HOME.
   {
     MockEnvironment env;
-    env.Set("HOME", "/home/user");
+    base::ScopedPathOverride home_override(base::DIR_HOME,
+                                           base::FilePath("/home/user"),
+                                           true /* absolute? */,
+                                           false /* create? */);
     env.Set("XDG_DATA_HOME", "/user/path");
-    base::FilePath path;
-    ASSERT_TRUE(GetDataWriteLocation(&env, &path));
+    base::FilePath path = GetDataWriteLocation(&env);
     EXPECT_EQ("/user/path", path.value());
   }
 
   // Test that $XDG_DATA_HOME falls back to $HOME/.local/share.
   {
     MockEnvironment env;
-    env.Set("HOME", "/home/user");
-    base::FilePath path;
-    ASSERT_TRUE(GetDataWriteLocation(&env, &path));
+    base::ScopedPathOverride home_override(base::DIR_HOME,
+                                           base::FilePath("/home/user"),
+                                           true /* absolute? */,
+                                           false /* create? */);
+    base::FilePath path = GetDataWriteLocation(&env);
     EXPECT_EQ("/home/user/.local/share", path.value());
   }
-
-  // Test that if neither $XDG_DATA_HOME nor $HOME are specified, it fails.
-  {
-    MockEnvironment env;
-    base::FilePath path;
-    ASSERT_FALSE(GetDataWriteLocation(&env, &path));
-  }
 }
 
 TEST(ShellIntegrationTest, GetDataSearchLocations) {
   base::MessageLoop message_loop;
   content::TestBrowserThread file_thread(BrowserThread::FILE, &message_loop);
 
   // Test that it returns $XDG_DATA_HOME + $XDG_DATA_DIRS.
   {
     MockEnvironment env;
-    env.Set("HOME", "/home/user");
+    base::ScopedPathOverride home_override(base::DIR_HOME,
+                                           base::FilePath("/home/user"),
+                                           true /* absolute? */,
+                                           false /* create? */);
     env.Set("XDG_DATA_HOME", "/user/path");
     env.Set("XDG_DATA_DIRS", "/system/path/1:/system/path/2");
     EXPECT_THAT(
         FilePathsToStrings(GetDataSearchLocations(&env)),
         ElementsAre("/user/path",
                     "/system/path/1",
                     "/system/path/2"));
   }
 
   // Test that $XDG_DATA_HOME falls back to $HOME/.local/share.
   {
     MockEnvironment env;
-    env.Set("HOME", "/home/user");
+    base::ScopedPathOverride home_override(base::DIR_HOME,
+                                           base::FilePath("/home/user"),
+                                           true /* absolute? */,
+                                           false /* create? */);
     env.Set("XDG_DATA_DIRS", "/system/path/1:/system/path/2");
     EXPECT_THAT(
         FilePathsToStrings(GetDataSearchLocations(&env)),
         ElementsAre("/home/user/.local/share",
                     "/system/path/1",
                     "/system/path/2"));
   }
 
   // Test that if neither $XDG_DATA_HOME nor $HOME are specified, it still
   // succeeds.
   {
     MockEnvironment env;
     env.Set("XDG_DATA_DIRS", "/system/path/1:/system/path/2");
-    EXPECT_THAT(
-        FilePathsToStrings(GetDataSearchLocations(&env)),
-        ElementsAre("/system/path/1",
-                    "/system/path/2"));
+    std::vector<std::string> results =
+        FilePathsToStrings(GetDataSearchLocations(&env));
+    ASSERT_EQ(3U, results.size());
+    EXPECT_FALSE(results[0].empty());
+    EXPECT_EQ("/system/path/1", results[1]);
+    EXPECT_EQ("/system/path/2", results[2]);
   }
 
   // Test that $XDG_DATA_DIRS falls back to the two default paths.
   {
     MockEnvironment env;
-    env.Set("HOME", "/home/user");
+    base::ScopedPathOverride home_override(base::DIR_HOME,
+                                           base::FilePath("/home/user"),
+                                           true /* absolute? */,
+                                           false /* create? */);
     env.Set("XDG_DATA_HOME", "/user/path");
     EXPECT_THAT(
         FilePathsToStrings(GetDataSearchLocations(&env)),
         ElementsAre("/user/path",
                     "/usr/local/share",
                     "/usr/share"));
   }
 }
 
 TEST(ShellIntegrationTest, GetExistingShortcutLocations) {
@@ skipping 129 matching lines @@
         GetExistingShortcutContents(&env, kTemplateFilepath, &contents));
     EXPECT_EQ(kTestData1, contents);
   }
 
   // Test that it falls back to $HOME/.local/share/applications.
   {
     base::ScopedTempDir temp_dir;
     ASSERT_TRUE(temp_dir.CreateUniqueTempDir());
 
     MockEnvironment env;
-    env.Set("HOME", temp_dir.path().value());
+    base::ScopedPathOverride home_override(base::DIR_HOME,
+                                           temp_dir.path(),
+                                           true /* absolute? */,
+                                           false /* create? */);
     ASSERT_TRUE(base::CreateDirectory(
         temp_dir.path().Append(".local/share/applications")));
     ASSERT_TRUE(WriteString(
         temp_dir.path().Append(".local/share/applications")
             .Append(kTemplateFilename),
         kTestData1));
     std::string contents;
     ASSERT_TRUE(
         GetExistingShortcutContents(&env, kTemplateFilepath, &contents));
     EXPECT_EQ(kTestData1, contents);
@@ skipping 304 matching lines @@
 
   for (size_t i = 0; i < arraysize(test_cases); i++) {
     SCOPED_TRACE(i);
     EXPECT_EQ(test_cases[i].expected_output,
               GetDirectoryFileContents(base::ASCIIToUTF16(test_cases[i].title),
                                        test_cases[i].icon_name));
   }
 }
 
 }  // namespace shell_integration_linux