net/disk_cache/blockfile/file_win.cc - Issue 826973002: replace COMPILE_ASSERT with static_assert in net/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/disk_cache/blockfile/file_win.cc

Issue 826973002: replace COMPILE_ASSERT with static_assert in net/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase on master Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/disk_cache/blockfile/file_win.cc

diff --git a/net/disk_cache/blockfile/file_win.cc b/net/disk_cache/blockfile/file_win.cc

index bf313128b4631d5bb517a9c54d8fa6657b957c7d..ccc0439cc9d401afa1b523a47f71e75454be6f5c 100644

--- a/net/disk_cache/blockfile/file_win.cc

+++ b/net/disk_cache/blockfile/file_win.cc

@@ -26,7 +26,8 @@ struct MyOverlapped {

disk_cache::FileIOCallback* callback_;

};

-COMPILE_ASSERT(!offsetof(MyOverlapped, context_), starts_with_overlapped);

+static_assert(!offsetof(MyOverlapped, context_),

Deprecated (see juliatuttle) 2015/01/05 22:22:39 This would be clearer as "offsetof(...) == 0", if

Mostyn Bramley-Moore 2015/01/06 00:07:07 Done.

+ "should start with overlapped");

// Helper class to handle the IO completion notifications from the message loop.

class CompletionHandler : public base::MessageLoopForIO::IOHandler {