Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 826953002: replace COMPILE_ASSERT with static_assert in media/ (Closed)

Created:
5 years, 12 months ago by Mostyn Bramley-Moore
Modified:
5 years, 11 months ago
Reviewers:
xhwang
CC:
chromium-reviews, yusukes+watch_chromium.org, tzik, hguihot+watch_chromium.org, mikhal+watch_chromium.org, teravest+watch_chromium.org, nfullagar1, ben+mojo_chromium.org, miu+watch_chromium.org, viettrungluu+watch_chromium.org, raymes+watch_chromium.org, abarth-chromium, eme-reviews_chromium.org, hubbe+watch_chromium.org, ihf+watch_chromium.org, imcheng+watch_chromium.org, qsr+mojo_chromium.org, jasonroberts+watch_google.com, binji+watch_chromium.org, feature-media-reviews_chromium.org, yzshen+watch_chromium.org, piman+watch_chromium.org, hclam+watch_chromium.org, avayvod+watch_chromium.org, pwestin+watch_google.com, Aaron Boodman, darin (slow to review), noelallen1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

replace COMPILE_ASSERT with static_assert in media/ BUG=442514 Committed: https://crrev.com/502b00b39ec4ecc5e9e745fd22a00cc196209008 Cr-Commit-Position: refs/heads/master@{#309999}

Patch Set 1 #

Patch Set 2 : rebase on master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -100 lines) Patch
M media/audio/audio_input_device.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M media/audio/audio_output_device.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M media/audio/cras/cras_input.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M media/base/audio_bus.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M media/base/audio_splicer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/base/key_systems_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M media/base/video_frame.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/blink/webmediaplayer_impl.cc View 2 chunks +16 lines, -16 lines 0 comments Download
M media/blink/webmediaplayer_util.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M media/blink/webmediasource_impl.cc View 1 chunk +8 lines, -8 lines 0 comments Download
M media/cast/receiver/audio_decoder.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M media/cast/receiver/video_decoder.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M media/cast/sender/h264_vt_encoder.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M media/cdm/ppapi/cdm_adapter.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M media/cdm/ppapi/cdm_wrapper.h View 2 chunks +6 lines, -6 lines 0 comments Download
M media/cdm/ppapi/supported_cdm_versions.h View 2 chunks +6 lines, -6 lines 0 comments Download
M media/ffmpeg/ffmpeg_common.cc View 2 chunks +8 lines, -8 lines 0 comments Download
M media/filters/audio_renderer_algorithm.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M media/filters/chunk_demuxer_unittest.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M media/filters/fake_demuxer_stream_unittest.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M media/filters/h264_bitstream_buffer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M media/filters/h264_parser.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M media/formats/webm/webm_cluster_parser_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M media/mojo/interfaces/media_types.mojom View 6 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Mostyn Bramley-Moore
@xhwang: please take a look.
5 years, 11 months ago (2015-01-05 21:53:46 UTC) #2
xhwang
lgtm
5 years, 11 months ago (2015-01-05 22:09:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/826953002/20001
5 years, 11 months ago (2015-01-05 22:12:16 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-05 23:44:15 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-05 23:46:24 UTC) #7
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/502b00b39ec4ecc5e9e745fd22a00cc196209008
Cr-Commit-Position: refs/heads/master@{#309999}

Powered by Google App Engine
This is Rietveld 408576698