Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(966)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 826933003: Update idle extension API to use BrowserContext. (Closed)

Created:
5 years, 11 months ago by Daniel Erat
Modified:
5 years, 11 months ago
Reviewers:
James Cook, dcheng
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update idle extension API to use BrowserContext. As a first step toward moving the chrome.idle API to //extensions, update it to use content::BrowserContext rather than Profile. BUG=446320 Committed: https://crrev.com/a51ad4b0672985d2404eef75c281a69225197b11 Cr-Commit-Position: refs/heads/master@{#310122}

Patch Set 1 #

Total comments: 4

Patch Set 2 : make BrowserContext members const #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -33 lines) Patch
M chrome/browser/extensions/api/idle/idle_api.h View 2 chunks +3 lines, -3 lines 2 comments Download
M chrome/browser/extensions/api/idle/idle_api.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/idle/idle_api_unittest.cc View 2 chunks +8 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/idle/idle_manager.h View 1 3 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/idle/idle_manager.cc View 1 6 chunks +13 lines, -13 lines 0 comments Download
M chrome/browser/extensions/api/idle/idle_manager_factory.h View 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/idle/idle_manager_factory.cc View 3 chunks +5 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
Daniel Erat
5 years, 11 months ago (2015-01-06 18:44:15 UTC) #2
dcheng
lgtm https://codereview.chromium.org/826933003/diff/1/chrome/browser/extensions/api/idle/idle_manager.cc File chrome/browser/extensions/api/idle/idle_manager.cc (right): https://codereview.chromium.org/826933003/diff/1/chrome/browser/extensions/api/idle/idle_manager.cc#newcode39 chrome/browser/extensions/api/idle/idle_manager.cc:39: content::BrowserContext* context_; Ditto https://codereview.chromium.org/826933003/diff/1/chrome/browser/extensions/api/idle/idle_manager.h File chrome/browser/extensions/api/idle/idle_manager.h (right): https://codereview.chromium.org/826933003/diff/1/chrome/browser/extensions/api/idle/idle_manager.h#newcode124 ...
5 years, 11 months ago (2015-01-06 18:49:05 UTC) #3
Daniel Erat
thanks for the quick review! https://codereview.chromium.org/826933003/diff/1/chrome/browser/extensions/api/idle/idle_manager.cc File chrome/browser/extensions/api/idle/idle_manager.cc (right): https://codereview.chromium.org/826933003/diff/1/chrome/browser/extensions/api/idle/idle_manager.cc#newcode39 chrome/browser/extensions/api/idle/idle_manager.cc:39: content::BrowserContext* context_; On 2015/01/06 ...
5 years, 11 months ago (2015-01-06 18:52:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/826933003/20001
5 years, 11 months ago (2015-01-06 18:53:40 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-06 20:08:33 UTC) #7
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/a51ad4b0672985d2404eef75c281a69225197b11 Cr-Commit-Position: refs/heads/master@{#310122}
5 years, 11 months ago (2015-01-06 20:10:27 UTC) #8
James Cook
Retroactive LGTM :-) https://codereview.chromium.org/826933003/diff/20001/chrome/browser/extensions/api/idle/idle_api.h File chrome/browser/extensions/api/idle/idle_api.h (right): https://codereview.chromium.org/826933003/diff/20001/chrome/browser/extensions/api/idle/idle_api.h#newcode14 chrome/browser/extensions/api/idle/idle_api.h:14: class IdleQueryStateFunction : public AsyncExtensionFunction { ...
5 years, 11 months ago (2015-01-06 20:47:50 UTC) #9
Daniel Erat
5 years, 11 months ago (2015-01-13 22:26:07 UTC) #10
Message was sent while issue was closed. 
https://codereview.chromium.org/826933003/diff/20001/chrome/browser/extension...
File chrome/browser/extensions/api/idle/idle_api.h (right):

https://codereview.chromium.org/826933003/diff/20001/chrome/browser/extension...
chrome/browser/extensions/api/idle/idle_api.h:14: class IdleQueryStateFunction :
public AsyncExtensionFunction {
On 2015/01/06 20:47:49, James Cook wrote:
> For a future CL -- I've been trying to convert these to
> UIThreadExtensionFunction() and Run().

sure, i'm including this in my change to actually move the api.

Powered by Google App Engine
This is Rietveld 408576698