Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Unified Diff: Source/bindings/scripts/code_generator_v8.pm

Issue 82693003: IDL compiler: [CustomToV8] interface (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebased, remove excess files Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/bindings/scripts/unstable/v8_interface.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/scripts/code_generator_v8.pm
diff --git a/Source/bindings/scripts/code_generator_v8.pm b/Source/bindings/scripts/code_generator_v8.pm
index d19b273811774295ffbfcc69698a24f6f3db561c..e1346c71d66c05c1df17e3ba50b53978eb2f309c 100644
--- a/Source/bindings/scripts/code_generator_v8.pm
+++ b/Source/bindings/scripts/code_generator_v8.pm
@@ -907,6 +907,7 @@ END
die "Can't suppress toV8 for subclass\n" if $interface->parent;
} elsif ($noWrap) {
$header{nameSpaceWebCore}->add(<<END);
+
class ${nativeType};
v8::Handle<v8::Value> toV8(${nativeType}*, v8::Handle<v8::Object> creationContext, v8::Isolate*);
@@ -927,7 +928,6 @@ inline void v8SetReturnValueFast(const CallbackInfo& callbackInfo, ${nativeType}
{
v8SetReturnValue(callbackInfo, toV8(impl, callbackInfo.Holder(), callbackInfo.GetIsolate()));
}
-
END
} else {
if ($customWrap) {
@@ -5058,6 +5058,7 @@ END
v8::Handle<v8::Object> wrapper = ${v8ClassName}::createWrapper(impl, creationContext, isolate);
END
if ($isDocument) {
+ AddToImplIncludes("bindings/v8/ScriptController.h");
AddToImplIncludes("bindings/v8/V8WindowShell.h");
$code .= <<END;
if (wrapper.IsEmpty())
@@ -5087,8 +5088,6 @@ sub GenerateToV8Converters
return;
}
- AddToImplIncludes("bindings/v8/ScriptController.h");
-
GenerateSpecialWrap($interface, $v8ClassName, $nativeType);
my $createWrapperArgumentType = GetPassRefPtrType($nativeType);
@@ -5122,6 +5121,7 @@ END
END
if (InheritsInterface($interface, "Document")) {
+ AddToImplIncludes("bindings/v8/ScriptController.h");
AddToImplIncludes("core/frame/Frame.h");
$code .= <<END;
if (Frame* frame = impl->frame()) {
« no previous file with comments | « no previous file | Source/bindings/scripts/unstable/v8_interface.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698