Source/core/rendering/RenderGrid.h - Issue 826893003: [CSS Grid Layout] Remove stack from grid-auto-flow syntax

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderGrid.h

Issue 826893003: [CSS Grid Layout] Remove stack from grid-auto-flow syntax (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@remove-stack

Patch Set: Adding perftests Created 5 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/css/parser/CSSPropertyParser.cpp ('K') | « Source/core/css/resolver/StyleBuilderConverter.cpp ('k') | Source/core/rendering/RenderGrid.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/RenderGrid.h

diff --git a/Source/core/rendering/RenderGrid.h b/Source/core/rendering/RenderGrid.h

index 11ed43ad4bc3ac7a010417006af8dc279d1bd3fa..d40a7733b91e5e4987c933f757604ebef0ae8b84 100644

--- a/Source/core/rendering/RenderGrid.h

+++ b/Source/core/rendering/RenderGrid.h

@@ -66,7 +66,7 @@ private:

virtual void computePreferredLogicalWidths() override;

virtual void addChild(RenderObject* newChild, RenderObject* beforeChild = 0) override;

- void addChildToIndexesMap(RenderBox&);

+ void addChildToIndexesMap(RenderBox& child);

Julien - ping for review 2015/01/05 13:11:34 Unneeded parameter (the name of the function makes

virtual void removeChild(RenderObject*) override;

virtual void styleDidChange(StyleDifference, const RenderStyle*) override;

@@ -157,9 +157,13 @@ private:

return m_grid.size();

}

+ bool hasAutoPlacedItems() const { return m_hasAutoPlacedItems; }

+ void setHasAutoPlacedItems() { m_hasAutoPlacedItems = true; }

typedef Vector<Vector<GridCell> > GridRepresentation;

GridRepresentation m_grid;

bool m_gridIsDirty;

+ bool m_hasAutoPlacedItems;

Vector<LayoutUnit> m_rowPositions;

Vector<LayoutUnit> m_columnPositions;

HashMap<const RenderBox*, GridCoordinate> m_gridItemCoordinate;

« Source/core/css/parser/CSSPropertyParser.cpp ('K') | « Source/core/css/resolver/StyleBuilderConverter.cpp ('k') | Source/core/rendering/RenderGrid.cpp » ('j') | no next file with comments »