Source/core/css/CSSComputedStyleDeclaration.cpp - Issue 826893003: [CSS Grid Layout] Remove stack from grid-auto-flow syntax

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/CSSComputedStyleDeclaration.cpp

Issue 826893003: [CSS Grid Layout] Remove stack from grid-auto-flow syntax (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@remove-stack

Patch Set: Adding perftests Created 5 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« PerformanceTests/Layout/grid-add-auto-positioned-items.html ('K') | « PerformanceTests/Layout/grid-add-positioned-items.html ('k') | Source/core/css/CSSValueKeywords.in » ('j') | Source/core/css/parser/CSSPropertyParser.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/css/CSSComputedStyleDeclaration.cpp

diff --git a/Source/core/css/CSSComputedStyleDeclaration.cpp b/Source/core/css/CSSComputedStyleDeclaration.cpp

index 8c258eb1f5b43d6dc427616ddcb07530e7bdff8c..210060cab481f1e5ad5e690759dac5bcbe9727f7 100644

--- a/Source/core/css/CSSComputedStyleDeclaration.cpp

+++ b/Source/core/css/CSSComputedStyleDeclaration.cpp

@@ -1950,10 +1950,6 @@ PassRefPtrWillBeRawPtr<CSSValue> CSSComputedStyleDeclaration::getPropertyCSSValu

case AutoFlowColumnDense:

list->append(cssValuePool().createIdentifierValue(CSSValueColumn));

break;

- case AutoFlowStackRow:

- case AutoFlowStackColumn:

- list->append(cssValuePool().createIdentifierValue(CSSValueStack));

- break;

default:

ASSERT_NOT_REACHED();

}

@@ -1963,12 +1959,6 @@ PassRefPtrWillBeRawPtr<CSSValue> CSSComputedStyleDeclaration::getPropertyCSSValu

case AutoFlowColumnDense:

list->append(cssValuePool().createIdentifierValue(CSSValueDense));

break;

- case AutoFlowStackRow:

- list->append(cssValuePool().createIdentifierValue(CSSValueRow));

- break;

- case AutoFlowStackColumn:

- list->append(cssValuePool().createIdentifierValue(CSSValueColumn));

- break;

default:

// Do nothing.

break;