[CSS Grid Layout] Remove stack from grid-auto-flow syntax

[CSS Grid Layout] Remove stack from grid-auto-flow syntax

"stack" mode for grid-auto-flow property has been removed from the grid
layout spec:
http://dev.w3.org/csswg/css-grid/#propdef-grid-auto-flow

New syntax is:
  [ row | column ] || dense

Modified parsing in order to adapt it to the new syntax.

Also the current behavior relying on "stack" has been updated following
the spec. Now it won't be possible to mimic the old "none" (or "stack")
unless you specify manually the grid-placement properties.

Update layout tests in order to adapt the results to the new behavior.
ietestcenter/css3/grid/grid-column-002.htm was removed as
it doesn't make sense without "stack".

BUG=384099
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188381

[Manuel Rego, 2014-12-26 15:31:47]

rego@igalia.com changed reviewers:
+ cbiesinger@chromium.org, jchaffraix@chromium.org, leviw@chromium.org

[Manuel Rego, 2014-12-26 15:31:48]

This patch removes "stack" and the old "none" support.

The problem is that now in RenderGridd::addChild() and
RenderGridd::removeChild() we always have to dirty the grid as it might contain
auto-placed items that can change their positions.

I've uploaded a different CL adding a flag to check if we have or not
auto-placed items at:
https://codereview.chromium.org/826893003

[Manuel Rego, 2015-01-09 11:42:44]

On 2014/12/26 15:31:48, Manuel Rego wrote:
> This patch removes "stack" and the old "none" support.
> 
> The problem is that now in RenderGridd::addChild() and
> RenderGridd::removeChild() we always have to dirty the grid as it might
contain
> auto-placed items that can change their positions.
> 
> I've uploaded a different CL adding a flag to check if we have or not
> auto-placed items at:
> https://codereview.chromium.org/826893003

As we agreed in the other CL the results of the flag were not
good enough to justify the complexity.
You can check the data at:
https://codereview.chromium.org/826893003/#msg8

So, I've just uploaded a new version of this patch, applying the changes
related to the tests commented in the review of the other CL.

Please, take a look to this patch. Thanks!

[Julien - ping for review, 2015-01-14 09:19:28]

The CQ bit was checked by jchaffraix@chromium.org

[Julien - ping for review, 2015-01-14 09:19:29]

lgtm

[commit-bot: I haz the power, 2015-01-14 09:19:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/826893002/20001

[commit-bot: I haz the power, 2015-01-14 09:20:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-14 09:20:10]

Failed to apply patch for Source/core/css/CSSComputedStyleDeclaration.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/css/CSSComputedStyleDeclaration.cpp
  Hunk #1 FAILED at 1950.
  Hunk #2 FAILED at 1963.
  2 out of 2 hunks FAILED -- saving rejects to file
Source/core/css/CSSComputedStyleDeclaration.cpp.rej

Patch:       Source/core/css/CSSComputedStyleDeclaration.cpp
Index: Source/core/css/CSSComputedStyleDeclaration.cpp
diff --git a/Source/core/css/CSSComputedStyleDeclaration.cpp
b/Source/core/css/CSSComputedStyleDeclaration.cpp
index
8c258eb1f5b43d6dc427616ddcb07530e7bdff8c..210060cab481f1e5ad5e690759dac5bcbe9727f7
100644
--- a/Source/core/css/CSSComputedStyleDeclaration.cpp
+++ b/Source/core/css/CSSComputedStyleDeclaration.cpp
@@ -1950,10 +1950,6 @@ PassRefPtrWillBeRawPtr<CSSValue>
CSSComputedStyleDeclaration::getPropertyCSSValu
             case AutoFlowColumnDense:
                
list->append(cssValuePool().createIdentifierValue(CSSValueColumn));
                 break;
-            case AutoFlowStackRow:
-            case AutoFlowStackColumn:
-               
list->append(cssValuePool().createIdentifierValue(CSSValueStack));
-                break;
             default:
                 ASSERT_NOT_REACHED();
             }
@@ -1963,12 +1959,6 @@ PassRefPtrWillBeRawPtr<CSSValue>
CSSComputedStyleDeclaration::getPropertyCSSValu
             case AutoFlowColumnDense:
                
list->append(cssValuePool().createIdentifierValue(CSSValueDense));
                 break;
-            case AutoFlowStackRow:
-               
list->append(cssValuePool().createIdentifierValue(CSSValueRow));
-                break;
-            case AutoFlowStackColumn:
-               
list->append(cssValuePool().createIdentifierValue(CSSValueColumn));
-                break;
             default:
                 // Do nothing.
                 break;

[Manuel Rego, 2015-01-14 10:07:07]

The CQ bit was checked by rego@igalia.com

[commit-bot: I haz the power, 2015-01-14 10:08:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/826893002/40001

[commit-bot: I haz the power, 2015-01-14 10:15:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-14 10:15:12]

Try jobs failed on following builders:
  blink_presubmit on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/2...)

[Manuel Rego, 2015-01-14 10:30:36]

The CQ bit was checked by rego@igalia.com

[commit-bot: I haz the power, 2015-01-14 10:31:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/826893002/40001

[commit-bot: I haz the power, 2015-01-14 10:38:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-14 10:38:08]

Try jobs failed on following builders:
  blink_presubmit on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/2...)

[Manuel Rego, 2015-01-14 11:07:48]

The CQ bit was checked by rego@igalia.com

[commit-bot: I haz the power, 2015-01-14 11:07:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/826893002/40001

[commit-bot: I haz the power, 2015-01-14 13:36:07]

Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188381