ios/public/test/test_chrome_provider_initializer.h - Issue 826803003: Cleanup in ios/chrome and ios/public/test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/public/test/test_chrome_provider_initializer.h

Issue 826803003: Cleanup in ios/chrome and ios/public/test. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/public/test/test_chrome_provider_initializer.h

diff --git a/ios/public/test/test_chrome_provider_initializer.h b/ios/public/test/test_chrome_provider_initializer.h

index 268b01b2eb3b4ba7eb92574cfc5a679dd4b328b1..b3ae3ff5cbfbc32224d5a76467e0d02b8c4e06a3 100644

--- a/ios/public/test/test_chrome_provider_initializer.h

+++ b/ios/public/test/test_chrome_provider_initializer.h

@@ -5,6 +5,8 @@

#ifndef IOS_PUBLIC_TEST_TEST_CHROME_PROVIDER_INITIALIZER_H_

#define IOS_PUBLIC_TEST_TEST_CHROME_PROVIDER_INITIALIZER_H_

+#include "base/memory/scoped_ptr.h"

namespace ios {

class TestChromeBrowserProvider;

@@ -18,7 +20,7 @@ class TestChromeProviderInitializer {

virtual ~TestChromeProviderInitializer();

private:

- TestChromeBrowserProvider* chrome_browser_provider_;

+ scoped_ptr<TestChromeBrowserProvider> chrome_browser_provider_;

};

Alexei Svitkine (slow) 2015/01/08 18:39:40 Nit: Probably add DISALLOW_COPY_AND_ASSIGN() here

droger 2015/01/08 18:48:42 Done.

} // namespace ios

« no previous file with comments | « ios/ios_tests.gyp ('k') | ios/public/test/test_chrome_provider_initializer.cc » ('j') | no next file with comments »