Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 826803003: Cleanup in ios/chrome and ios/public/test. (Closed)

Created:
5 years, 11 months ago by droger
Modified:
5 years, 2 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup in ios/chrome and ios/public/test. Follow up CL for https://codereview.chromium.org/809333003/. Committed: https://crrev.com/54eb6ec174493b43f95b00bbaeffe19d4326a694 Cr-Commit-Position: refs/heads/master@{#310565}

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -6 lines) Patch
M ios/chrome/browser/translate/translate_service_ios.h View 2 chunks +3 lines, -0 lines 0 comments Download
M ios/ios_tests.gyp View 1 chunk +2 lines, -1 line 0 comments Download
M ios/public/test/test_chrome_provider_initializer.h View 1 2 chunks +6 lines, -1 line 0 comments Download
M ios/public/test/test_chrome_provider_initializer.cc View 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
droger
5 years, 11 months ago (2015-01-08 18:10:26 UTC) #6
Alexei Svitkine (slow)
lgtm https://codereview.chromium.org/826803003/diff/80001/ios/public/test/test_chrome_provider_initializer.h File ios/public/test/test_chrome_provider_initializer.h (right): https://codereview.chromium.org/826803003/diff/80001/ios/public/test/test_chrome_provider_initializer.h#newcode24 ios/public/test/test_chrome_provider_initializer.h:24: }; Nit: Probably add DISALLOW_COPY_AND_ASSIGN() here too.
5 years, 11 months ago (2015-01-08 18:39:40 UTC) #8
droger
Thanks https://codereview.chromium.org/826803003/diff/80001/ios/public/test/test_chrome_provider_initializer.h File ios/public/test/test_chrome_provider_initializer.h (right): https://codereview.chromium.org/826803003/diff/80001/ios/public/test/test_chrome_provider_initializer.h#newcode24 ios/public/test/test_chrome_provider_initializer.h:24: }; On 2015/01/08 18:39:40, Alexei Svitkine wrote: > ...
5 years, 11 months ago (2015-01-08 18:48:43 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/826803003/100001
5 years, 11 months ago (2015-01-08 18:49:51 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:100001)
5 years, 11 months ago (2015-01-08 19:43:06 UTC) #12
commit-bot: I haz the power
5 years, 11 months ago (2015-01-08 19:44:23 UTC) #13
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/54eb6ec174493b43f95b00bbaeffe19d4326a694
Cr-Commit-Position: refs/heads/master@{#310565}

Powered by Google App Engine
This is Rietveld 408576698