Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1085)

Issue 826743003: Update {virtual,override,final} to follow C++11 style chrome/browser/chromeos/net. (Closed)

Created:
5 years, 11 months ago by dcheng
Modified:
5 years, 11 months ago
Reviewers:
xiyuan
CC:
cbentzel+watch_chromium.org, chromium-reviews, davemoore+watch_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update {virtual,override,final} to follow C++11 style chrome/browser/chromeos/net. The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override. This patch was automatically generated with a ChromeOS build using a variation of https://codereview.chromium.org/598073004. BUG=417463 R=xiyuan@chromium.org Committed: https://crrev.com/e099f7cfd7a940d60592bff5f3ebb6b6c9fe2a8a Cr-Commit-Position: refs/heads/master@{#311760}

Patch Set 1 #

Messages

Total messages: 10 (3 generated)
dcheng
5 years, 11 months ago (2015-01-15 21:13:21 UTC) #1
xiyuan
lgtm
5 years, 11 months ago (2015-01-15 21:15:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/826743003/1
5 years, 11 months ago (2015-01-15 21:17:24 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/1477)
5 years, 11 months ago (2015-01-15 22:53:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/826743003/1
5 years, 11 months ago (2015-01-15 22:58:30 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-15 23:18:14 UTC) #9
commit-bot: I haz the power
5 years, 11 months ago (2015-01-15 23:19:10 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e099f7cfd7a940d60592bff5f3ebb6b6c9fe2a8a
Cr-Commit-Position: refs/heads/master@{#311760}

Powered by Google App Engine
This is Rietveld 408576698