Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(958)

Unified Diff: Source/devtools/front_end/sources/WatchExpressionsSidebarPane.js

Issue 826713005: DevTools: Highlight changed scope variables as they change (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: addressing feedback. v good points. simplified Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/devtools/front_end/sources/ScopeChainSidebarPane.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/sources/WatchExpressionsSidebarPane.js
diff --git a/Source/devtools/front_end/sources/WatchExpressionsSidebarPane.js b/Source/devtools/front_end/sources/WatchExpressionsSidebarPane.js
index 1180e98e48442091053aaa7e9ada5a931687d40c..bad9bebec7bcd2739767c56f6d2c6a29d469cbdd 100644
--- a/Source/devtools/front_end/sources/WatchExpressionsSidebarPane.js
+++ b/Source/devtools/front_end/sources/WatchExpressionsSidebarPane.js
@@ -36,7 +36,10 @@ WebInspector.WatchExpressionsSidebarPane = function()
{
WebInspector.SidebarPane.call(this, WebInspector.UIString("Watch Expressions"));
- this.section = new WebInspector.WatchExpressionsSection();
+ /** @type {!WebInspector.ObjectPropertiesMemento} */
+ this.memento = new WebInspector.ObjectPropertiesMemento();
+
+ this.section = new WebInspector.WatchExpressionsSection(this.memento);
this.bodyElement.appendChild(this.section.element);
var refreshButton = this.titleElement.createChild("button", "pane-title-button refresh");
@@ -100,12 +103,16 @@ WebInspector.WatchExpressionsSidebarPane.prototype = {
/**
* @constructor
* @extends {WebInspector.PropertiesSection}
+ * @param {!WebInspector.ObjectPropertiesMemento} memento
*/
-WebInspector.WatchExpressionsSection = function()
+WebInspector.WatchExpressionsSection = function(memento)
{
this._watchObjectGroupId = "watch-group";
WebInspector.PropertiesSection.call(this, "");
+
+ this.memento = memento;
+
this.treeElementConstructor = WebInspector.ObjectPropertyTreeElement;
this.skipProto = false;
@@ -222,6 +229,8 @@ WebInspector.WatchExpressionsSection.prototype = {
*/
updateProperties: function(properties)
{
+ this.memento.forgetProperties();
+
this.propertiesTreeOutline.removeChildren();
WebInspector.ObjectPropertyTreeElement.populateWithProperties(this.propertiesTreeOutline, properties, [],
WebInspector.WatchExpressionTreeElement, WebInspector.WatchExpressionsSection.CompareProperties, false, null);
« no previous file with comments | « Source/devtools/front_end/sources/ScopeChainSidebarPane.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698