Source/devtools/front_end/sources/ScopeChainSidebarPane.js - Issue 826713005: DevTools: Highlight changed scope variables as they change

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/devtools/front_end/sources/ScopeChainSidebarPane.js

Issue 826713005: DevTools: Highlight changed scope variables as they change (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: addressing feedback Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/devtools/front_end/components/ObjectPropertiesSection.js ('K') | « Source/devtools/front_end/components/ObjectPropertiesSection.js ('k') | Source/devtools/front_end/sources/WatchExpressionsSidebarPane.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/devtools/front_end/sources/ScopeChainSidebarPane.js

diff --git a/Source/devtools/front_end/sources/ScopeChainSidebarPane.js b/Source/devtools/front_end/sources/ScopeChainSidebarPane.js

index f4e554fe7e14a5678e2a0f1d5bafd5ed61f74c19..94925529675baa9e1b6d3ecb0a09c727af81c8d5 100644

--- a/Source/devtools/front_end/sources/ScopeChainSidebarPane.js

+++ b/Source/devtools/front_end/sources/ScopeChainSidebarPane.js

@@ -128,9 +128,8 @@ WebInspector.ScopeChainSidebarPane.prototype = {

else

var scopeObject = runtimeModel.createRemoteObject(scope.object);

- var section = new WebInspector.ObjectPropertiesSection(scopeObject, title, subtitle, emptyPlaceholder, true, extraProperties, WebInspector.ScopeVariableTreeElement);

+ var section = new WebInspector.ObjectPropertiesSection(scopeObject, title, subtitle, emptyPlaceholder, true, extraProperties, WebInspector.ScopeVariableTreeElement, this);

section.editInSelectedCallFrameWhenPaused = true;

- section.pane = this;

if (scope.type === DebuggerAgent.ScopeType.Global)

section.collapse();