Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Side by Side Diff: Source/devtools/front_end/sources/ScopeChainSidebarPane.js

Issue 826713005: DevTools: Highlight changed scope variables as they change (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: addressing feedback Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008 Apple Inc. All Rights Reserved. 2 * Copyright (C) 2008 Apple Inc. All Rights Reserved.
3 * Copyright (C) 2011 Google Inc. All rights reserved. 3 * Copyright (C) 2011 Google Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 110 matching lines...) Expand 10 before | Expand all | Expand 10 after
121 var subtitle = declarativeScope ? undefined : scope.object.descripti on; 121 var subtitle = declarativeScope ? undefined : scope.object.descripti on;
122 if (!title || title === subtitle) 122 if (!title || title === subtitle)
123 subtitle = undefined; 123 subtitle = undefined;
124 124
125 var runtimeModel = callFrame.target().runtimeModel; 125 var runtimeModel = callFrame.target().runtimeModel;
126 if (declarativeScope) 126 if (declarativeScope)
127 var scopeObject = runtimeModel.createScopeRemoteObject(scope.obj ect, new WebInspector.ScopeRef(i, callFrame.id, undefined)); 127 var scopeObject = runtimeModel.createScopeRemoteObject(scope.obj ect, new WebInspector.ScopeRef(i, callFrame.id, undefined));
128 else 128 else
129 var scopeObject = runtimeModel.createRemoteObject(scope.object); 129 var scopeObject = runtimeModel.createRemoteObject(scope.object);
130 130
131 var section = new WebInspector.ObjectPropertiesSection(scopeObject, title, subtitle, emptyPlaceholder, true, extraProperties, WebInspector.ScopeVari ableTreeElement); 131 var section = new WebInspector.ObjectPropertiesSection(scopeObject, title, subtitle, emptyPlaceholder, true, extraProperties, WebInspector.ScopeVari ableTreeElement, this);
132 section.editInSelectedCallFrameWhenPaused = true; 132 section.editInSelectedCallFrameWhenPaused = true;
133 section.pane = this;
134 133
135 if (scope.type === DebuggerAgent.ScopeType.Global) 134 if (scope.type === DebuggerAgent.ScopeType.Global)
136 section.collapse(); 135 section.collapse();
137 else if (!foundLocalScope || scope.type === DebuggerAgent.ScopeType. Local || this._expandedSections.has(title)) 136 else if (!foundLocalScope || scope.type === DebuggerAgent.ScopeType. Local || this._expandedSections.has(title))
138 section.expand(); 137 section.expand();
139 138
140 this._sections.push(section); 139 this._sections.push(section);
141 this.bodyElement.appendChild(section.element); 140 this.bodyElement.appendChild(section.element);
142 } 141 }
143 }, 142 },
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
181 { 180 {
182 if (!this._propertyIdentifier) { 181 if (!this._propertyIdentifier) {
183 var section = this.treeOutline.section; 182 var section = this.treeOutline.section;
184 this._propertyIdentifier = section.title + ":" + (section.subtitle ? section.subtitle + ":" : "") + WebInspector.ObjectPropertyTreeElement.prototype .propertyPath.call(this); 183 this._propertyIdentifier = section.title + ":" + (section.subtitle ? section.subtitle + ":" : "") + WebInspector.ObjectPropertyTreeElement.prototype .propertyPath.call(this);
185 } 184 }
186 return this._propertyIdentifier; 185 return this._propertyIdentifier;
187 }, 186 },
188 187
189 __proto__: WebInspector.ObjectPropertyTreeElement.prototype 188 __proto__: WebInspector.ObjectPropertyTreeElement.prototype
190 } 189 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698