Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1279)

Unified Diff: content/renderer/render_widget.cc

Issue 826713002: [ChromeOS] Show autofill popup after keyboard (if any) is shown. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Disable autofill popup waiting for keyboard when keyboard has been disabled. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/common/view_messages.h ('k') | ui/base/ime/dummy_input_method.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_widget.cc
diff --git a/content/renderer/render_widget.cc b/content/renderer/render_widget.cc
index 0d59d32116cb54d7a18fb264ac2d95e5cb55eb8c..f814d478883c12a89f06a86ab51af6a9c6fff6b6 100644
--- a/content/renderer/render_widget.cc
+++ b/content/renderer/render_widget.cc
@@ -703,6 +703,7 @@ bool RenderWidget::OnMessageReceived(const IPC::Message& message) {
IPC_MESSAGE_HANDLER(ViewMsg_SetTextDirection, OnSetTextDirection)
IPC_MESSAGE_HANDLER(ViewMsg_Move_ACK, OnRequestMoveAck)
IPC_MESSAGE_HANDLER(ViewMsg_UpdateScreenRects, OnUpdateScreenRects)
+ IPC_MESSAGE_HANDLER(ViewMsg_FocusChangeComplete, FocusChangeComplete)
#if defined(OS_ANDROID)
IPC_MESSAGE_HANDLER(ViewMsg_ShowImeIfNeeded, OnShowImeIfNeeded)
IPC_MESSAGE_HANDLER(ViewMsg_ImeEventAck, OnImeEventAck)
@@ -1240,9 +1241,9 @@ void RenderWidget::OnHandleInputEvent(const blink::WebInputEvent* input_event,
DidHandleTouchEvent(*(static_cast<const WebTouchEvent*>(input_event)));
}
-// TODO(rouslan): Fix ChromeOS and Windows 8 behavior of autofill popup with
-// virtual keyboard.
-#if !defined(OS_ANDROID)
+// TODO(rouslan): Fix Windows 8 behavior of autofill popup with virtual
+// keyboard.
+#if !defined(OS_ANDROID) && !defined(OS_CHROMEOS)
// Virtual keyboard is not supported, so react to focus change immediately.
if (processed && (input_event->type == WebInputEvent::TouchEnd ||
input_event->type == WebInputEvent::MouseUp)) {
@@ -1705,9 +1706,9 @@ void RenderWidget::OnShowImeIfNeeded() {
UpdateTextInputState(SHOW_IME_IF_NEEDED, FROM_NON_IME);
#endif
-// TODO(rouslan): Fix ChromeOS and Windows 8 behavior of autofill popup with
-// virtual keyboard.
-#if !defined(OS_ANDROID)
+// TODO(rouslan): Fix Windows 8 behavior of autofill popup with virtual
+// keyboard.
+#if !defined(OS_ANDROID) && !defined(OS_CHROMEOS)
FocusChangeComplete();
#endif
}
« no previous file with comments | « content/common/view_messages.h ('k') | ui/base/ime/dummy_input_method.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698